Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2628053002: Fixes #28338 (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes #28338 Fix await/cascade bug and corresponding test. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/df45dacb88216f5a30f5b6c5926a2b655213d595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/dev_compiler/lib/src/compiler/js_metalet.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language_strong/await_in_cascade_test.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 11 months ago (2017-01-11 20:34:09 UTC) #3
Jennifer Messerly
LGTM. I got deja vu from that fix :)
3 years, 11 months ago (2017-01-11 20:35:25 UTC) #4
vsm
3 years, 11 months ago (2017-01-11 20:37:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df45dacb88216f5a30f5b6c5926a2b655213d595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698