Gtk3: Render a GtkHeaderBar as the background of the tab strip

ui/views/window/custom_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/custom_frame_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/strings/utf_string_conversions.h"
@@ skipping 202 matching lines @@
   active_ = active;
   SchedulePaint();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // CustomFrameView, View overrides:
 
 void CustomFrameView::OnPaint(gfx::Canvas* canvas) {
   if (!ShouldShowTitleBarAndBorder())
     return;
 

[sky, 2017/01/11 21:54:52]

Any reason not to call set_is_active here? Calling set_is_active here seems less
error prone.

[Tom (Use chromium acct), 2017/01/11 22:44:48]

I added the set_is_active right after set_frame_color, which is what used to
handle active/nonactive colors.  Maybe move all of the set_* here?

[sky, 2017/01/12 00:58:14]

SGTM

[Tom (Use chromium acct), 2017/01/12 01:47:29]

Done.

   if (frame_->IsMaximized())
     PaintMaximizedFrameBorder(canvas);
   else
     PaintRestoredFrameBorder(canvas);
   PaintTitleBar(canvas);
   if (ShouldShowClientEdge())
     PaintRestoredClientEdge(canvas);
 }
 
 void CustomFrameView::Layout() {
@@ skipping 119 matching lines @@
 
   return true;
 }
 
 bool CustomFrameView::ShouldShowClientEdge() const {
   return !frame_->IsMaximized() && ShouldShowTitleBarAndBorder();
 }
 
 void CustomFrameView::PaintRestoredFrameBorder(gfx::Canvas* canvas) {
   frame_background_->set_frame_color(GetFrameColor());
+  frame_background_->set_is_active(ShouldPaintAsActive());
   const gfx::ImageSkia frame_image = GetFrameImage();
   frame_background_->set_theme_image(frame_image);
   frame_background_->set_top_area_height(frame_image.height());
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   frame_background_->SetCornerImages(
       rb.GetImageNamed(IDR_WINDOW_TOP_LEFT_CORNER).ToImageSkia(),
       rb.GetImageNamed(IDR_WINDOW_TOP_RIGHT_CORNER).ToImageSkia(),
       rb.GetImageNamed(IDR_WINDOW_BOTTOM_LEFT_CORNER).ToImageSkia(),
@@ skipping 265 matching lines @@
     }
     case views::FRAME_BUTTON_CLOSE: {
       button = close_button_;
       break;
     }
   }
   return button;
 }
 
 }  // namespace views