Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 262803004: [Android WebView] Enable WebAudio API. (Closed)

Created:
6 years, 7 months ago by benm (inactive)
Modified:
6 years, 7 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android WebView] Enable WebAudio API. BUG=368240 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267845

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix up comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/common.gypi View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
benm (inactive)
Hi Raymond, I'm enabling WebAudio for ARM32 and x86 as the other backends seem to ...
6 years, 7 months ago (2014-05-01 17:31:54 UTC) #1
Raymond Toy
lgtm with nit. I think arm32 is well tested; x86 is somewhat tested. I don't ...
6 years, 7 months ago (2014-05-01 17:37:08 UTC) #2
benm (inactive)
Thanks, I am planning to work with Intel folks for x86/x64 testing. https://codereview.chromium.org/262803004/diff/1/build/common.gypi File build/common.gypi ...
6 years, 7 months ago (2014-05-01 17:40:18 UTC) #3
benm (inactive)
The CQ bit was checked by benm@chromium.org
6 years, 7 months ago (2014-05-01 17:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
6 years, 7 months ago (2014-05-01 17:44:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 18:41:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 18:41:11 UTC) #7
benm (inactive)
The CQ bit was checked by benm@chromium.org
6 years, 7 months ago (2014-05-01 21:49:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
6 years, 7 months ago (2014-05-01 21:49:43 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 23:18:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 23:18:17 UTC) #11
benm (inactive)
The CQ bit was checked by benm@chromium.org
6 years, 7 months ago (2014-05-02 06:35:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
6 years, 7 months ago (2014-05-02 06:35:33 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 07:06:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 07:06:59 UTC) #15
benm (inactive)
The CQ bit was checked by benm@chromium.org
6 years, 7 months ago (2014-05-02 07:46:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
6 years, 7 months ago (2014-05-02 07:46:34 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 17:36:24 UTC) #18
Message was sent while issue was closed.
Change committed as 267845

Powered by Google App Engine
This is Rietveld 408576698