|
|
Created:
6 years, 7 months ago by benm (inactive) Modified:
6 years, 7 months ago Reviewers:
Raymond Toy CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Description[Android WebView] Enable WebAudio API.
BUG=368240
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267845
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix up comment. #Messages
Total messages: 18 (0 generated)
Hi Raymond, I'm enabling WebAudio for ARM32 and x86 as the other backends seem to be progressing well, and to give us an opportunity to shake out any latent issues with the current implementations. Does that sound good?
lgtm with nit. I think arm32 is well tested; x86 is somewhat tested. I don't have any experience with x64, but it shouldn't be worse than x86, so enabling in webview is ok with me. https://codereview.chromium.org/262803004/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/262803004/diff/1/build/common.gypi#oldcode858 build/common.gypi:858: # without webview. When enabled, this will also enable Nit: Fix the comment about "without webview".
Thanks, I am planning to work with Intel folks for x86/x64 testing. https://codereview.chromium.org/262803004/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/262803004/diff/1/build/common.gypi#oldcode858 build/common.gypi:858: # without webview. When enabled, this will also enable good catch!
The CQ bit was checked by benm@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by benm@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by benm@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by benm@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/262803004/20001
Message was sent while issue was closed.
Change committed as 267845 |