Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2628013002: Don't instantiate a new InterfaceTypeImpl for a ClassElement without type parameters. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't instantiate a new InterfaceTypeImpl for a ClassElement without type parameters. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/31f08c798a849ec73f62bf542fade1c03f1eb2c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-11 17:35:20 UTC) #1
Paul Berry
lgtm
3 years, 11 months ago (2017-01-11 19:01:31 UTC) #2
scheglov
3 years, 11 months ago (2017-01-11 19:15:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31f08c798a849ec73f62bf542fade1c03f1eb2c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698