Issue 26280007: Split file_observers.h into three files for each class

Issue 26280007: Split file_observers.h into three files for each class (Closed)

Created:
7 years, 2 months ago by kinuko

Modified:
7 years ago

Reviewers:
nhiroki, Paweł Hajdan Jr.

CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, nhiroki+watch_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split file_observers.h into three files for each class Prerequisite changes for moving files from webkit/ to content/ (public interfaces need to be 1:1 module:file) BUG=265769 TEST=build

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -94 lines)			Patch
M	chrome/browser/sync_file_system/local/local_file_change_tracker.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/syncable_file_system_util.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/test/test_file_system_backend.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	webkit/browser/fileapi/file_access_observer.h	View	1 chunk	+29 lines, -0 lines	1 comment	Download
A	webkit/browser/fileapi/file_change_observer.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
D	webkit/browser/fileapi/file_observers.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	webkit/browser/fileapi/file_update_observer.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/mock_file_change_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/obfuscated_file_util.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_stream_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_quota_observer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/storage_browser.gyp	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kinuko

pawel: mind doing owner's review in content/public/test change? (include file name changes only)

7 years, 2 months ago (2013-10-08 09:48:52 UTC) #3

jam

https://codereview.chromium.org/26280007/diff/1/webkit/browser/fileapi/file_access_observer.h File webkit/browser/fileapi/file_access_observer.h (right): https://codereview.chromium.org/26280007/diff/1/webkit/browser/fileapi/file_access_observer.h#newcode21 webkit/browser/fileapi/file_access_observer.h:21: virtual void OnAccess(const FileSystemURL& url) = 0; btw we ...

7 years, 2 months ago (2013-10-08 16:07:29 UTC) #5

kinuko

On 2013/10/08 16:07:29, jam wrote: > https://codereview.chromium.org/26280007/diff/1/webkit/browser/fileapi/file_access_observer.h > File webkit/browser/fileapi/file_access_observer.h (right): > > https://codereview.chromium.org/26280007/diff/1/webkit/browser/fileapi/file_access_observer.h#newcode21 > ...

7 years, 2 months ago (2013-10-09 03:45:30 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/26280007/1

7 years, 2 months ago (2013-10-09 03:49:27 UTC) #7

commit-bot: I haz the power

7 years, 2 months ago (2013-10-09 05:36:22 UTC) #8

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

Expand Messages | Collapse Messages