Language settings: Wait 100ms to close language action menu on checkbox change

chrome/test/data/webui/settings/languages_page_browsertest.js

Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index fe801319e8b187340d4c17438e8bf3c891bb113b..a7e1dd9673e32a6dc906821bab903fb4cb14851c 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -235,6 +235,33 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
             cr.isChromeOS || cr.isWindows ? 1 : 0, separator.offsetHeight);
       });
 
+      test('toggle translate', function(done) {
+        // Enable Translate so the menu always shows the Translate checkbox.
+        languageHelper.setPrefValue('translate.enabled', true);
+        languagesPage.set('languages.translateTarget', 'foo');
+        languagesPage.set('languages.enabled.1.supportsTranslate', true);
+
+        var languageOptionsDropdownTrigger =
+            languagesCollapse.querySelectorAll('paper-icon-button')[1];
+        assertTrue(!!languageOptionsDropdownTrigger);
+        MockInteractions.tap(languageOptionsDropdownTrigger);
+        assertTrue(actionMenu.open);
+
+        // Toggle the translate option.
+        var translateOption = actionMenu.querySelector('#offerTranslations');
+        assertTrue(!!translateOption);
+        assertFalse(translateOption.disabled);
+        MockInteractions.tap(translateOption);
+
+        // Menu should stay open briefly.
+        assertTrue(actionMenu.open);
+        // Guaranteed to run later than the menu close delay.

[dschuyler, 2017/01/14 01:15:36]

Could you point me to docs or something so I can understand why this would be
true? i.e. I would not intuitively expect that

setTimeout(..., 8);
and
setTimeout(..., 9);

will necessarily execute that that exact order. I would think that if they get
delayed they may pile up. iiuc, the guarantee is that they will not execute
sooner than the timeout, but may execute at some arbitrary time after the
timeout.

BTW, even if this didn't normally guarantee the order, I guess I only really
need to know that the order will guaranteed for chromium unit test (which may
help make the explanation easier). 

This seems to reinforce this (unless I'm misunderstanding these docs):
"There are a number of reasons why a timeout may take longer to fire than
anticipated." From
https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/se...

[michaelpg, 2017/01/14 04:39:13]

Totally right that the actual timeout is not guaranteed. But the callbacks are
well-ordered according to the spec, and the order is what matters. For these two
statements:

1. setTimeout(fn1, n1)
2. setTimeout(fn2, n2)

if n1 <= n2, fn1 runs before fn2. Thus kMenuCloseDelay + 1 ensures the menu
close callback has been called first.

Source:
https://html.spec.whatwg.org/multipage/webappapis.html#timer-initialisation-s...

The task (function) is not queued until after this step:

"Wait until any invocations of this algorithm that had the same method context
[window], that started before this one, and whose timeout is equal to or less
than this one's, have completed."

The task must be queued on the same task queue as other tasks from the "timer
task source", and tasks on a queue are executed in queue order.

[dschuyler, 2017/01/17 19:30:06]

Thanks! I really appreciate the detail provided.

+        setTimeout(function() {
+          assertFalse(actionMenu.open);
+          done();
+        }, settings.kMenuCloseDelay + 1);
+      });
+
       test('remove language', function() {
         var numEnabled = languagesPage.languages.enabled.length;