Language settings: Wait 100ms to close language action menu on checkbox change

chrome/browser/resources/settings/languages_page/languages_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-languages-page' is the settings page
  * for language and input method settings.
  */
+cr.exportPath('settings');
+
+/**
+ * @const {number} Millisecond delay that can be used when closing an action
+ *      menu to keep it briefly on-screen.
+ */
+settings.kMenuCloseDelay = 100;
+
 (function() {
 'use strict';
 
 Polymer({
   is: 'settings-languages-page',
 
   properties: {
     /**
      * Preferences state.
      */
@@ skipping 140 matching lines @@
    * @param {!{target: !PaperCheckboxElement}} e
    * @private
    */
   onUILanguageChange_: function(e) {
     // We don't support unchecking this checkbox. TODO(michaelpg): Ask for a
     // simpler widget.
     assert(e.target.checked);
     this.languageHelper.setProspectiveUILanguage(
         this.detailLanguage_.language.code);
 
-    /** @type {!CrActionMenuElement} */(this.$.menu.get()).close();
+    this.closeMenuSoon_();
   },
 
-   /**
+  /**
    * @param {!chrome.languageSettingsPrivate.Language} language
    * @param {string} targetLanguageCode The default translate target language.
    * @return {boolean} True if the translate checkbox should be disabled.
    * @private
    */
   disableTranslateCheckbox_: function(language, targetLanguageCode) {
     if (!language.supportsTranslate)
       return true;
 
     return this.languageHelper.convertLanguageCodeForTranslate(language.code) ==
         targetLanguageCode;
   },
 
   /**
    * Handler for changes to the translate checkbox.
    * @param {!{target: !PaperCheckboxElement}} e
    * @private
    */
   onTranslateCheckboxChange_: function(e) {
     if (e.target.checked) {
       this.languageHelper.enableTranslateLanguage(
           this.detailLanguage_.language.code);
     } else {
       this.languageHelper.disableTranslateLanguage(
           this.detailLanguage_.language.code);
     }
-    /** @type {!CrActionMenuElement} */(this.$.menu.get()).close();
+    this.closeMenuSoon_();
   },
 
   /**
    * Returns "complex" if the menu includes checkboxes, which should change the
    * spacing of items and show a separator in the menu.
    * @param {boolean} translateEnabled
    * @return {string}
    */
   getMenuClass_: function(translateEnabled) {
     if (translateEnabled || cr.isChromeOS || cr.isWindows)
@@ skipping 276 matching lines @@
 
     // The UI language choice doesn't persist for guests.
     if (cr.isChromeOS &&
         (uiAccountTweaks.UIAccountTweaks.loggedInAsGuest() ||
          uiAccountTweaks.UIAccountTweaks.loggedInAsPublicAccount())) {
       menu.querySelector('#uiLanguageItem').hidden = true;
     }
   },
 
   /**
+   * Closes the shared action menu after a short delay, so when a checkbox is
+   * tapped it can be seen to change state before disappearing.
+   * @private
+   */
+  closeMenuSoon_: function() {
+    var menu = /** @type {!CrActionMenuElement} */(this.$.menu.get());
+    setTimeout(function() {
+      if (menu.open)
+        menu.close();
+    }, settings.kMenuCloseDelay);
+  },
+
+  /**
    * Handler for the restart button.
    * @private
    */
   onRestartTap_: function() {
 // <if expr="chromeos">
     settings.LifetimeBrowserProxyImpl.getInstance().signOutAndRestart();
 // </if>
 // <if expr="not chromeos">
     settings.LifetimeBrowserProxyImpl.getInstance().restart();
 // </if>
@@ skipping 10 matching lines @@
     if (e.target.tagName == expandButtonTag)
       return;
 
     /** @type {!CrExpandButtonElement} */
     var expandButton = e.currentTarget.querySelector(expandButtonTag);
     assert(expandButton);
     expandButton.expanded = !expandButton.expanded;
   },
 });
 })();