Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ash/root_window_controller.cc

Issue 2627963004: Hide virtual keyboard before removing it from view hierarchy. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller.cc
diff --git a/ash/root_window_controller.cc b/ash/root_window_controller.cc
index 78b101441c362e1800a1565b99474d7a32501ee9..a008960f4a8b9c620c29b5bd1c1b85134933acea 100644
--- a/ash/root_window_controller.cc
+++ b/ash/root_window_controller.cc
@@ -677,10 +677,11 @@ void RootWindowController::DeactivateKeyboard(
aura::Window* parent =
GetContainer(kShellWindowId_ImeWindowParentContainer);
DCHECK(parent);
+ // Virtual keyboard may be deactivated while still showing, hide the
+ // keyboard before removing it from view hierarchy.
+ keyboard_controller->HideKeyboard(
+ keyboard::KeyboardController::HIDE_REASON_AUTOMATIC);
parent->RemoveChild(keyboard_container);
- // Virtual keyboard may be deactivated while still showing, notify all
- // observers that keyboard bounds changed to 0 before remove them.
- keyboard_controller->NotifyKeyboardBoundsChanging(gfx::Rect());
keyboard_controller->RemoveObserver(wm_shelf_->shelf_layout_manager());
keyboard_controller->RemoveObserver(panel_layout_manager());
keyboard_controller->RemoveObserver(docked_window_layout_manager());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698