Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2627963004: Hide virtual keyboard before removing it from view hierarchy. (Closed)

Created:
3 years, 11 months ago by yhanada
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide virtual keyboard before removing it from view hierarchy. BUG=303429 TEST=Manual. Check that no black area appears when the virtual keyboard moves between displays.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ash/root_window_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yhanada
Hi oshima, PTAL.
3 years, 11 months ago (2017-01-12 12:48:18 UTC) #6
oshima
lgtm
3 years, 11 months ago (2017-01-13 00:56:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627963004/1
3 years, 11 months ago (2017-01-13 01:10:05 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:09:12 UTC) #12
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698