Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 2627953005: Make workers inherit the large heap limit of the main isolate. (Closed)
Patch Set: fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
index 5a4c8e106647d16c1f85cdb0ddbe00a8736e4ff0..8a516063a6010e1f50ec8feb18a62dee900e4703 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
@@ -449,6 +449,10 @@ void WebEmbeddedWorkerImpl::startWorkerThread() {
std::unique_ptr<WorkerSettings> workerSettings =
WTF::wrapUnique(new WorkerSettings(document->settings()));
+ WorkerV8Settings workerV8Settings = WorkerV8Settings::Default();
+ workerV8Settings.m_v8CacheOptions =
+ static_cast<V8CacheOptions>(m_workerStartData.v8CacheOptions);
+
std::unique_ptr<WorkerThreadStartupData> startupData =
WorkerThreadStartupData::create(
scriptURL, m_workerStartData.userAgent, m_mainScriptLoader->script(),
@@ -457,7 +461,7 @@ void WebEmbeddedWorkerImpl::startWorkerThread() {
m_mainScriptLoader->getReferrerPolicy(), starterOrigin, workerClients,
m_mainScriptLoader->responseAddressSpace(),
m_mainScriptLoader->originTrialTokens(), std::move(workerSettings),
- static_cast<V8CacheOptions>(m_workerStartData.v8CacheOptions));
+ workerV8Settings);
m_mainScriptLoader.clear();

Powered by Google App Engine
This is Rietveld 408576698