third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp - Issue 2627953005: Make workers inherit the large heap limit of the main isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Issue 2627953005: Make workers inherit the large heap limit of the main isolate. (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

index 1cffd5c367c23c44f519682d0dcd645739e4a5c2..f46b5c9d34a5e19b21e005283563576732229f40 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

@@ -281,7 +281,7 @@ TEST_F(WorkerThreadTest, Terminate_WhileDebuggerTaskIsRunningOnInitialization) {

PauseWorkerGlobalScopeOnStart, headers.get(), "",

m_securityOrigin.get(), nullptr, /* workerClients */

WebAddressSpaceLocal, nullptr /* originTrialToken */,

- nullptr /* WorkerSettings */, V8CacheOptionsDefault);

+ nullptr /* WorkerSettings */, WorkerV8Settings::Default());

m_workerThread->start(std::move(startupData));

// Used to wait for worker thread termination in a debugger task on the