third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp - Issue 2627953005: Make workers inherit the large heap limit of the main isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

Issue 2627953005: Make workers inherit the large heap limit of the main isolate. (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

index 6026c0979c57bfb4c3b9d8b5bfa5b925539ab79b..576c9f6e5393120a360d3d56f32d015a4abd2b91 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

@@ -123,13 +123,18 @@ void InProcessWorkerMessagingProxy::startWorkerGlobalScope(

workerInspectorProxy()->workerStartMode(document);

std::unique_ptr<WorkerSettings> workerSettings =

WTF::wrapUnique(new WorkerSettings(document->settings()));

+ WorkerV8Settings workerV8Settings(WorkerV8Settings::Default());

+ workerV8Settings.m_heapLimitMode =

+ toIsolate(document)->IsHeapLimitIncreasedForDebugging()

+ ? WorkerV8Settings::HeapLimitMode::IncreasedForDebugging

+ : WorkerV8Settings::HeapLimitMode::Default;

std::unique_ptr<WorkerThreadStartupData> startupData =

WorkerThreadStartupData::create(

scriptURL, userAgent, sourceCode, nullptr, startMode,

csp->headers().get(), referrerPolicy, starterOrigin,

m_workerClients.release(), document->addressSpace(),

OriginTrialContext::getTokens(document).get(),

- std::move(workerSettings));

+ std::move(workerSettings), workerV8Settings);

initializeWorkerThread(std::move(startupData));

workerInspectorProxy()->workerThreadCreated(document, workerThread(),