Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html

Issue 2627953003: Make `getComputedStyle` return the correct style for collapsed <img> elements. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html b/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html
index 714b255d2481e733cb8f33c97e266eb53f4c173d..4a9e5bd2ba836b1fe0096e199e371006f4a17308 100644
--- a/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html
+++ b/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed-after-redirect.html
@@ -16,6 +16,8 @@ async_test(t => {
i.onload = t.step_func_done(_ => {
assert_equals(i.clientWidth, 100, "Images that are not disallowed should be displayed at their natural width.");
assert_equals(i.clientHeight, 100, "Images that are not disallowed should be displayed at their natural height.");
+ let style = window.getComputedStyle(i);
+ assert_equals(style.display, "inline", "Images that are not disallowed should be display:inline");
});
i.onerror = t.unreached_func();
i.src = "http://localhost:8000/resources/redirect.php?url=/subresource_filter/resources/alpha.png";
@@ -30,6 +32,8 @@ async_test(t => {
assert_equals(i.clientHeight, 0, "Images that are disallowed should be collapsed.");
assert_equals(i.naturalWidth, 0, "Images that are disallowed should not be loaded.");
assert_equals(i.naturalHeight, 0, "Images that are disallowed should not be loaded.");
+ let style = window.getComputedStyle(i);
+ assert_equals(style.display, "none", "Images that are disallowed should be set to display:none");
});
i.src = "http://localhost:8000/resources/redirect.php?url=/subresource_filter/resources/beta.png";
document.body.append(i);

Powered by Google App Engine
This is Rietveld 408576698