VM: [Kernel] Fix remaining issues with kernel-based async/await implementation

VM: [Kernel] Fix remaining issues with kernel-based async/await implementation

This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/673eb56471006601d2c719a48b5b54eea7467996

[kustermann, 2017-01-11 10:15:04]

kustermann@google.com changed reviewers:
+ kmillikin@google.com, vegorov@google.com

[kustermann, 2017-01-11 10:15:04]

https://codereview.chromium.org/2627873002/diff/40001/tests/language/language...
File tests/language/language.status (right):

https://codereview.chromium.org/2627873002/diff/40001/tests/language/language...
tests/language/language.status:11: async_star_pause_test: Fail, OK
These 2 tests were failed before by the VM and since we're using effectively a
very similar approach we seem to fail in the same way. Haven't looked closely at
these, but they behave the same with JIT and JIT-kernel.

[kustermann, 2017-01-11 12:48:03]

Patchset #4 (id:60001) has been deleted

[kustermann, 2017-01-11 12:48:07]

Patchset #4 (id:80001) has been deleted

[kustermann, 2017-01-11 12:49:51]

Patchset #4 (id:100001) has been deleted

[kustermann, 2017-01-11 12:50:11]

PTAL

[Vyacheslav Egorov (Google), 2017-01-11 17:54:06]

lgtm

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
File pkg/kernel/lib/transformations/continuation.dart (right):

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
pkg/kernel/lib/transformations/continuation.dart:70: currentTryDepth++;
Please use prefix and postfix increment consistently.

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
pkg/kernel/lib/transformations/continuation.dart:84: currentTryDepth++;
ditto

[kustermann, 2017-01-11 18:34:55]

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
File pkg/kernel/lib/transformations/continuation.dart (right):

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
pkg/kernel/lib/transformations/continuation.dart:70: currentTryDepth++;
On 2017/01/11 17:54:05, Vyacheslav Egorov (Google) wrote:
> Please use prefix and postfix increment consistently. 

Done.

https://codereview.chromium.org/2627873002/diff/120001/pkg/kernel/lib/transfo...
pkg/kernel/lib/transformations/continuation.dart:84: currentTryDepth++;
On 2017/01/11 17:54:05, Vyacheslav Egorov (Google) wrote:
> ditto

Done.

[kustermann, 2017-01-11 18:35:10]

Description was changed from

==========
VM: [Kernel] Fix remaining issues with kernel-based async/await implementation

This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.
==========

to

==========
VM: [Kernel] Fix remaining issues with kernel-based async/await implementation

This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/673eb56471006601d2c719a48b5b54eea7467996
==========

[kustermann, 2017-01-11 18:35:11]

Committed patchset #5 (id:140001) manually as
673eb56471006601d2c719a48b5b54eea7467996 (presubmit successful).