Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: base/test/test_pending_task_info_unittest.cc

Issue 2627863002: Split Closure part of TestPendingTask out of the struct (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/test_pending_task_info.cc ('k') | base/test/test_pending_task_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_pending_task_info_unittest.cc
diff --git a/base/test/test_pending_task_unittest.cc b/base/test/test_pending_task_info_unittest.cc
similarity index 72%
rename from base/test/test_pending_task_unittest.cc
rename to base/test/test_pending_task_info_unittest.cc
index 6e01c8c66a65d57c67f92fea7feb2136780fd61f..8236c633505cc8773cc84fd2c2c89a0da2cd20eb 100644
--- a/base/test/test_pending_task_unittest.cc
+++ b/base/test/test_pending_task_info_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/test/test_pending_task.h"
+#include "base/test/test_pending_task_info.h"
#include "base/bind.h"
#include "base/trace_event/trace_event.h"
@@ -13,39 +13,40 @@
namespace base {
TEST(TestPendingTaskTest, TraceSupport) {
- base::TestPendingTask task;
+ base::TestPendingTaskInfo task_info;
// Check that TestPendingTask can be sent to the trace subsystem.
- TRACE_EVENT1("test", "TestPendingTask::TraceSupport", "task", task.AsValue());
+ TRACE_EVENT1("test", "TestPendingTask::TraceSupport", "task",
+ task_info.AsValue());
// Just a basic check that the trace output has *something* in it.
std::unique_ptr<base::trace_event::ConvertableToTraceFormat> task_value(
- task.AsValue());
+ task_info.AsValue());
EXPECT_THAT(task_value->ToString(), ::testing::HasSubstr("post_time"));
}
TEST(TestPendingTaskTest, ToString) {
- base::TestPendingTask task;
+ base::TestPendingTaskInfo task_info;
// Just a basic check that ToString has *something* in it.
- EXPECT_THAT(task.ToString(), ::testing::StartsWith("TestPendingTask("));
+ EXPECT_THAT(task_info.ToString(), ::testing::StartsWith("TestPendingTask("));
}
TEST(TestPendingTaskTest, GTestPrettyPrint) {
- base::TestPendingTask task;
+ base::TestPendingTaskInfo task_info;
// Check that gtest is calling the TestPendingTask's PrintTo method.
- EXPECT_THAT(::testing::PrintToString(task),
+ EXPECT_THAT(::testing::PrintToString(task_info),
::testing::StartsWith("TestPendingTask("));
// Check that pretty printing works with the gtest iostreams operator.
- EXPECT_NONFATAL_FAILURE(EXPECT_TRUE(false) << task, "TestPendingTask(");
+ EXPECT_NONFATAL_FAILURE(EXPECT_TRUE(false) << task_info, "TestPendingTask(");
}
TEST(TestPendingTaskTest, ShouldRunBefore) {
- base::TestPendingTask task_first;
+ base::TestPendingTaskInfo task_first;
task_first.delay = base::TimeDelta::FromMilliseconds(1);
- base::TestPendingTask task_after;
+ base::TestPendingTaskInfo task_after;
task_after.delay = base::TimeDelta::FromMilliseconds(2);
EXPECT_FALSE(task_after.ShouldRunBefore(task_first))
« no previous file with comments | « base/test/test_pending_task_info.cc ('k') | base/test/test_pending_task_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698