Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: base/test/scoped_mock_time_message_loop_task_runner_unittest.cc

Issue 2627863002: Split Closure part of TestPendingTask out of the struct (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/scoped_mock_time_message_loop_task_runner.h" 5 #include "base/test/scoped_mock_time_message_loop_task_runner.h"
6 6
7 #include <deque> 7 #include <deque>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/bind_helpers.h" 11 #include "base/bind_helpers.h"
12 #include "base/callback_forward.h" 12 #include "base/callback_forward.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/memory/ref_counted.h" 15 #include "base/memory/ref_counted.h"
16 #include "base/message_loop/message_loop.h" 16 #include "base/message_loop/message_loop.h"
17 #include "base/test/test_mock_time_task_runner.h" 17 #include "base/test/test_mock_time_task_runner.h"
18 #include "base/test/test_pending_task.h" 18 #include "base/test/test_pending_task_info.h"
19 #include "base/time/time.h" 19 #include "base/time/time.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 21
22 namespace base { 22 namespace base {
23 namespace { 23 namespace {
24 24
25 TaskRunner* GetCurrentTaskRunner() { 25 TaskRunner* GetCurrentTaskRunner() {
26 return MessageLoop::current()->task_runner().get(); 26 return MessageLoop::current()->task_runner().get();
27 } 27 }
28 28
29 // Pops a task from the front of |pending_tasks| and returns it. 29 void RecordTrue(bool* b) {
30 TestPendingTask PopFront(std::deque<TestPendingTask>* pending_tasks) { 30 *b = true;
31 TestPendingTask task = pending_tasks->front();
32 pending_tasks->pop_front();
33 return task;
34 } 31 }
35 32
36 class ScopedMockTimeMessageLoopTaskRunnerTest : public testing::Test { 33 class ScopedMockTimeMessageLoopTaskRunnerTest : public testing::Test {
37 public: 34 public:
38 ScopedMockTimeMessageLoopTaskRunnerTest() 35 ScopedMockTimeMessageLoopTaskRunnerTest()
39 : original_task_runner_(new TestMockTimeTaskRunner()) { 36 : original_task_runner_(new TestMockTimeTaskRunner()) {
40 MessageLoop::current()->SetTaskRunner(original_task_runner_); 37 MessageLoop::current()->SetTaskRunner(original_task_runner_);
41 } 38 }
42 39
43 protected: 40 protected:
(...skipping 18 matching lines...) Expand all
62 EXPECT_EQ(scoped_task_runner_->task_runner(), GetCurrentTaskRunner()); 59 EXPECT_EQ(scoped_task_runner_->task_runner(), GetCurrentTaskRunner());
63 scoped_task_runner_.reset(); 60 scoped_task_runner_.reset();
64 EXPECT_EQ(original_task_runner(), GetCurrentTaskRunner()); 61 EXPECT_EQ(original_task_runner(), GetCurrentTaskRunner());
65 } 62 }
66 63
67 TEST_F(ScopedMockTimeMessageLoopTaskRunnerTest, 64 TEST_F(ScopedMockTimeMessageLoopTaskRunnerTest,
68 IncompleteTasksAreCopiedToPreviousTaskRunnerAfterDestruction) { 65 IncompleteTasksAreCopiedToPreviousTaskRunnerAfterDestruction) {
69 auto scoped_task_runner_ = 66 auto scoped_task_runner_ =
70 base::MakeUnique<ScopedMockTimeMessageLoopTaskRunner>(); 67 base::MakeUnique<ScopedMockTimeMessageLoopTaskRunner>();
71 68
69 bool has_task_10_run = false;
70 bool has_task_11_run = false;
71
72 Closure task_1 = Bind(&DoNothing); 72 Closure task_1 = Bind(&DoNothing);
73 Closure task_2 = Bind(&DoNothing); 73 Closure task_2 = Bind(&DoNothing);
74 Closure task_10 = Bind(&DoNothing); 74 Closure task_10 = Bind(&RecordTrue, &has_task_10_run);
75 Closure task_11 = Bind(&DoNothing); 75 Closure task_11 = Bind(&RecordTrue, &has_task_11_run);
76 76
77 constexpr TimeDelta task_1_delay = TimeDelta::FromSeconds(1); 77 constexpr TimeDelta task_1_delay = TimeDelta::FromSeconds(1);
78 constexpr TimeDelta task_2_delay = TimeDelta::FromSeconds(2); 78 constexpr TimeDelta task_2_delay = TimeDelta::FromSeconds(2);
79 constexpr TimeDelta task_10_delay = TimeDelta::FromSeconds(10); 79 constexpr TimeDelta task_10_delay = TimeDelta::FromSeconds(10);
80 constexpr TimeDelta task_11_delay = TimeDelta::FromSeconds(11); 80 constexpr TimeDelta task_11_delay = TimeDelta::FromSeconds(11);
81 81
82 constexpr TimeDelta step_time_by = TimeDelta::FromSeconds(5); 82 constexpr TimeDelta step_time_by = TimeDelta::FromSeconds(5);
83 83
84 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_1, task_1_delay); 84 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_1, task_1_delay);
85 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_2, task_2_delay); 85 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_2, task_2_delay);
86 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_10, task_10_delay); 86 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_10, task_10_delay);
87 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_11, task_11_delay); 87 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_11, task_11_delay);
88 88
89 scoped_task_runner_->task_runner()->FastForwardBy(step_time_by); 89 scoped_task_runner_->task_runner()->FastForwardBy(step_time_by);
90 90
91 scoped_task_runner_.reset(); 91 scoped_task_runner_.reset();
92 92
93 std::deque<TestPendingTask> pending_tasks = 93 TestPendingTaskQueue pending_tasks =
94 original_task_runner()->TakePendingTasks(); 94 original_task_runner()->TakePendingTasks();
95
96 EXPECT_EQ(2U, pending_tasks.size()); 95 EXPECT_EQ(2U, pending_tasks.size());
97 96
98 TestPendingTask pending_task = PopFront(&pending_tasks); 97 TestPendingTaskInfo task_info = pending_tasks.front().first;
99 EXPECT_TRUE(task_10.Equals(pending_task.task)); 98 OnceClosure task = std::move(pending_tasks.front().second);
100 EXPECT_EQ(task_10_delay - step_time_by, pending_task.delay); 99 pending_tasks.pop_front();
101 100
102 pending_task = PopFront(&pending_tasks); 101 EXPECT_FALSE(has_task_10_run);
103 EXPECT_TRUE(task_11.Equals(pending_task.task)); 102 std::move(task).Run();
104 EXPECT_EQ(task_11_delay - step_time_by, pending_task.delay); 103 EXPECT_TRUE(has_task_10_run);
104 EXPECT_EQ(task_10_delay - step_time_by, task_info.delay);
105
106 task_info = pending_tasks.front().first;
107 task = std::move(pending_tasks.front().second);
108 pending_tasks.pop_front();
109 EXPECT_FALSE(has_task_11_run);
110 std::move(task).Run();
111 EXPECT_TRUE(has_task_11_run);
112 EXPECT_EQ(task_11_delay - step_time_by, task_info.delay);
105 } 113 }
106 114
107 } // namespace 115 } // namespace
108 } // namespace base 116 } // namespace base
OLDNEW
« no previous file with comments | « base/test/scoped_mock_time_message_loop_task_runner.cc ('k') | base/test/test_mock_time_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698