Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627793004: Fix more bots (TBR) (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/language/language_kernel.status View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
Committed patchset #1 (id:1) manually as f77340996bba4fa9740b1fa2b60ed660cbe0652d (presubmit successful).
3 years, 11 months ago (2017-01-12 17:23:55 UTC) #2
Brian Wilkerson
3 years, 11 months ago (2017-01-12 17:24:27 UTC) #4
kustermann
LGTM
3 years, 11 months ago (2017-01-12 17:25:35 UTC) #5
kustermann
https://codereview.chromium.org/2627793004/diff/1/tests/language/language_kernel.status File tests/language/language_kernel.status (right): https://codereview.chromium.org/2627793004/diff/1/tests/language/language_kernel.status#newcode90 tests/language/language_kernel.status:90: mixin_illegal_syntax_test/00: Crash Actually: This failure is not just in ...
3 years, 11 months ago (2017-01-12 18:23:33 UTC) #6
Brian Wilkerson
3 years, 11 months ago (2017-01-12 18:30:34 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2627793004/diff/1/tests/language/language_ker...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2627793004/diff/1/tests/language/language_ker...
tests/language/language_kernel.status:90: mixin_illegal_syntax_test/00: Crash
Do you mean that this should read:

mixin_illegal_syntax_test/00: DartkCrash

Powered by Google App Engine
This is Rietveld 408576698