Implement multitest failure expectations.

pkg/testing/lib/src/chain.dart

 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE.md file.
 
 library testing.chain;
 
 import 'dart:async' show
     Future,
     Stream;
 
@@ skipping 178 matching lines @@
             logStepComplete(completed, unexpectedResults.length,
                 descriptions.length, suite, description, lastStepRun);
             result = currentResult;
             if (currentResult.outcome == Expectation.PASS) {
               // The input to the next step is the output of this step.
               return doStep(result.output);
             }
           }
           if (description.multitestExpectations != null) {
             if (isError(description.multitestExpectations)) {
-              result = result.toNegativeTestResult();
+              result = toNegativeTestResult(
+                  result, description.multitestExpectations);
             }
           } else if (lastStep == lastStepRun &&
               description.shortName.endsWith("negative_test")) {
             if (result.outcome == Expectation.PASS) {
               result.addLog("Negative test didn't report an error.\n");
             } else if (result.outcome == Expectation.FAIL) {
               result.addLog("Negative test reported an error as expeceted.\n");
             }
-            result = result.toNegativeTestResult();
+            result = toNegativeTestResult(result);
           }
           if (!expectedOutcomes.contains(result.outcome)) {
             result.addLog("$sb");
             unexpectedResults[description] = result;
             unexpectedOutcomes[description] = expectedOutcomes;
             logUnexpectedResult(suite, description, result, expectedOutcomes);
           } else {
             logMessage(sb);
           }
           logTestComplete(++completed, unexpectedResults.length,
@@ skipping 90 matching lines @@
 
   Result.fail(O output, [error, StackTrace trace])
       : this(output, Expectation.FAIL, error, trace);
 
   String get log => logs.join();
 
   void addLog(String log) {
     logs.add(log);
   }
 
-  Result<O> toNegativeTestResult() {
-    Expectation outcome = this.outcome;
-    if (outcome == Expectation.PASS) {
-      outcome = Expectation.FAIL;
-    } else if (outcome == Expectation.FAIL) {
-      outcome = Expectation.PASS;
-    }
+  Result<O> copyWithOutcome(Expectation outcome) {
     return new Result<O>(output, outcome, error, trace)
         ..logs.addAll(logs);
   }
 }
 
 /// This is called from generated code.
 Future<Null> runChain(
     CreateContext f, Map<String, String> environment, Set<String> selectors,
     String json) {
   return withErrorHandling(() async {
     Chain suite = new Suite.fromJsonMap(Uri.base, JSON.decode(json));
     print("Running ${suite.name}");
     ChainContext context = await f(suite, environment);
     return context.run(suite, selectors);
   });
 }
+
+Result toNegativeTestResult(Result result, [Set<String> expectations]) {
+  Expectation outcome = result.outcome;
+  if (outcome == Expectation.PASS) {
+    if (expectations == null) {
+      outcome = Expectation.FAIL;
+    } else if (expectations.contains("compile-time error")) {
+      outcome = Expectation.MISSING_COMPILETIME_ERROR;
+    } else if (expectations.contains("runtime error") ||
+        expectations.contains("dynamic type error")) {
+      outcome = Expectation.MISSING_RUNTIME_ERROR;
+    } else {
+      outcome = Expectation.FAIL;
+    }
+  } else if (outcome == Expectation.FAIL) {
+    outcome = Expectation.PASS;
+  }
+  return result.copyWithOutcome(outcome);
+}