Add an UMA metric to track whether chrome is running on a tablet.

Add an UMA metric to track whether chrome is running on a tablet.

BUG=353701
R=cpu@chromium.org, isherman@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268825

[zturner, 2014-05-02 20:43:06]

+cpu for non-owners review first.  Can you think of any other edge cases I
should try to handle?

[zturner, 2014-05-05 18:23:54]

thakis:
  base/base.gyp
  chrome/browser/chrome_browser_main_win.cc
cpu:
  base/win/*
isherman:
  histograms.xml

[Ilya Sherman, 2014-05-05 21:57:54]

histograms lgtm

[cpu_(ooo_6.6-7.5), 2014-05-06 00:38:46]

lgtm other than that.

You need the uma folk review.

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc#new...
base/win/win_util.cc:242: return false;
please remove the less than xp branch.

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc#new...
base/win/win_util.cc:244: return (GetSystemMetrics(SM_TABLETPC) != 0);
mmmm, I was expecting you return false here. 

I mean say it is used like a tablet, do we want to treat it like a tablet?

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc#new...
base/win/win_util.cc:248: if (GetSystemMetrics(SM_SYSTEMDOCKED) != 0)
nice.

[zturner, 2014-05-06 00:49:35]

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/262773015/diff/20001/base/win/win_util.cc#new...
base/win/win_util.cc:244: return (GetSystemMetrics(SM_TABLETPC) != 0);
On 2014/05/06 00:38:46, cpu wrote:
> mmmm, I was expecting you return false here. 
> 
> I mean say it is used like a tablet, do we want to treat it like a tablet?

I would think yes?  I mean Windows XP tablets are a strange concept, so maybe we
want to exclude them just based on that alone.  But if we want to exclude
Windows XP tablets just because we don't want to support tablets on that OS,
then maybe the OS check should be at a higher level, like whoever calls this
function.

[Nico, 2014-05-06 02:49:38]

lgtm if cpu likes it

[cpu_(ooo_6.6-7.5), 2014-05-06 19:48:45]

lgtm w/ nits

https://codereview.chromium.org/262773015/diff/40001/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/262773015/diff/40001/base/win/win_util.cc#new...
base/win/win_util.cc:250: bool has_tablet_power_profile = false;
seems we can init has_table_power_profile in line 252

https://codereview.chromium.org/262773015/diff/40001/base/win/win_util.cc#new...
base/win/win_util.cc:254: has_tablet_power_profile |= (role ==
PlatformRoleSlate);
the bitwise or scares me. Can you change to good ol || ?

[cpu_(ooo_6.6-7.5), 2014-05-06 19:49:25]

> I would think yes?  

OK. leave as is.

[zturner, 2014-05-06 20:55:52]

The CQ bit was checked by zturner@chromium.org

[commit-bot: I haz the power, 2014-05-06 20:56:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zturner@chromium.org/262773015/60001

[commit-bot: I haz the power, 2014-05-07 03:01:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
  win_chromium_x64_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 10:15:49]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
  win_chromium_rel on tryserver.chromium
  win_chromium_x64_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 11:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 11:44:40]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[zturner, 2014-05-07 16:45:54]

Committed patchset #4 manually as r268825 (presubmit successful).