Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: pkg/kernel/test/treeshaker_dump.dart

Issue 2627723003: Improvements to the kernel tree shaker. (Closed)
Patch Set: Revert+Unrevert, and update status files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/test/treeshaker_bench.dart ('k') | pkg/kernel/test/treeshaker_membench.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/treeshaker_dump.dart
diff --git a/pkg/kernel/test/treeshaker_dump.dart b/pkg/kernel/test/treeshaker_dump.dart
index 8d1c7f4d9e46c1850620157871a8c8cbf565d220..0a380d1d44b3d073cba35f65ee1b4968df65625e 100644
--- a/pkg/kernel/test/treeshaker_dump.dart
+++ b/pkg/kernel/test/treeshaker_dump.dart
@@ -24,7 +24,8 @@ ArgParser parser = new ArgParser(allowTrailingOptions: true)
negatable: false)
..addOption('output',
help: 'The --diff files are written to the given directory instead of '
- 'the working directory');
+ 'the working directory')
+ ..addFlag('strong', help: 'Run the tree shaker in strong mode');
String usage = '''
Usage: treeshaker_dump [options] FILE.dill
@@ -60,8 +61,10 @@ main(List<String> args) {
exit(1);
}
+ bool strong = options['strong'];
+
Program program = loadProgramFromBinary(filename);
- TreeShaker shaker = new TreeShaker(program);
+ TreeShaker shaker = new TreeShaker(program, strongMode: strong);
int totalClasses = 0;
int totalInstantiationCandidates = 0;
int totalMembers = 0;
@@ -72,7 +75,7 @@ main(List<String> args) {
void visitMember(Member member) {
if (member.isAbstract) return; // Abstract members are not relevant.
++totalMembers;
- bool isUsed = shaker.isMemberUsed(member);
+ bool isUsed = shaker.isMemberBodyUsed(member);
if (isUsed) {
++usedMembers;
}
@@ -124,7 +127,7 @@ main(List<String> args) {
StringBuffer before = new StringBuffer();
new Printer(before, syntheticNames: names).writeProgramFile(program);
new File(beforeFile).writeAsStringSync('$before');
- new TreeShaker(program).transform(program);
+ new TreeShaker(program, strongMode: strong).transform(program);
StringBuffer after = new StringBuffer();
new Printer(after, syntheticNames: names).writeProgramFile(program);
new File(afterFile).writeAsStringSync('$after');
« no previous file with comments | « pkg/kernel/test/treeshaker_bench.dart ('k') | pkg/kernel/test/treeshaker_membench.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698