Improvements to the kernel tree shaker.

Improvements to the kernel tree shaker.

- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/71efbad90c07bece4010162b77d3b51e79b0a34d
Committed: https://github.com/dart-lang/sdk/commit/e6793f76eefa14fff3ff4fa2870e826fbee1f959

[asgerf, 2017-01-11 16:11:43]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[asgerf, 2017-01-19 11:14:45]

Ping

[Kevin Millikin (Google), 2017-01-19 11:40:20]

LGTM.

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/lib/transfor...
File pkg/kernel/lib/transformations/treeshaker.dart (right):

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/lib/transfor...
pkg/kernel/lib/transformations/treeshaker.dart:879: node.function.body = new
InvalidStatement()..parent = node.function;
Is there something else we could put here than InvalidStatement?

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/test/treesha...
File pkg/kernel/test/treeshaker_membench.dart (right):

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/test/treesha...
pkg/kernel/test/treeshaker_membench.dart:20: Usage: treeshaker_membench
[options] FILE.dart
This is also a binary input file.

[asgerf, 2017-01-19 11:46:31]

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/lib/transfor...
File pkg/kernel/lib/transformations/treeshaker.dart (right):

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/lib/transfor...
pkg/kernel/lib/transformations/treeshaker.dart:879: node.function.body = new
InvalidStatement()..parent = node.function;
On 2017/01/19 11:40:20, Kevin Millikin (Google) wrote:
> Is there something else we could put here than InvalidStatement?

Changed to a 'throw'. Should make it easier to debug.

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/test/treesha...
File pkg/kernel/test/treeshaker_membench.dart (right):

https://codereview.chromium.org/2627723003/diff/20001/pkg/kernel/test/treesha...
pkg/kernel/test/treeshaker_membench.dart:20: Usage: treeshaker_membench
[options] FILE.dart
On 2017/01/19 11:40:20, Kevin Millikin (Google) wrote:
> This is also a binary input file.

Thanks. Updated the usage string.

[asgerf, 2017-01-19 13:00:37]

Description was changed from

==========
Improvements to the kernel tree shaker.

- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.
==========

to

==========
Improvements to the kernel tree shaker.

- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/71efbad90c07bece4010162b77d3b51e79b0a34d
==========

[asgerf, 2017-01-19 13:00:40]

Committed patchset #4 (id:60001) manually as
71efbad90c07bece4010162b77d3b51e79b0a34d (presubmit successful).

[asgerf, 2017-01-20 09:52:33]

Description was changed from

==========
Improvements to the kernel tree shaker.

- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/71efbad90c07bece4010162b77d3b51e79b0a34d
==========

to

==========
Improvements to the kernel tree shaker.

- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/71efbad90c07bece4010162b77d3b51e79b0a34d
Committed:
https://github.com/dart-lang/sdk/commit/e6793f76eefa14fff3ff4fa2870e826fbee1f959
==========

[asgerf, 2017-01-20 09:52:34]

Committed patchset #5 (id:80001) manually as
e6793f76eefa14fff3ff4fa2870e826fbee1f959 (presubmit successful).