Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2627713011: Mark a now-passing test (Closed)

Created:
3 years, 11 months ago by Kevin Millikin (Google)
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark a now-passing test This test started passing, apparently because we stopped running heap verification code at shutdown when testing. The underlying issue or false positive is still there. It now appears with the VM flag --verify-on-transition. BUG=https://github.com/dart-lang/sdk/issues/28379 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/f32ef84dc5bf2a9c5e652177975590acaa988533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
3 years, 11 months ago (2017-01-13 09:53:20 UTC) #1
kustermann
LGTM
3 years, 11 months ago (2017-01-13 09:54:12 UTC) #2
Kevin Millikin (Google)
3 years, 11 months ago (2017-01-13 10:00:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f32ef84dc5bf2a9c5e652177975590acaa988533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698