Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2627713007: Move v8_breakpad_support_win from common to child (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move v8_breakpad_support_win from common to child Part of removing dependency of Windows browser DLL on v8. R=jochen@chromium.org BUG=581766

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -57 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/child/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/child/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/child/v8_breakpad_support_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/child/v8_breakpad_support_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/v8_breakpad_support_win.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/common/v8_breakpad_support_win.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
scottmg
3 years, 11 months ago (2017-01-12 00:20:38 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 08:37:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627713007/10001
3 years, 11 months ago (2017-01-12 15:57:44 UTC) #14
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 16:06:46 UTC) #17
scottmg
On 2017/01/12 16:06:46, commit-bot: I haz the power wrote: > Prior attempt to commit was ...
3 years, 11 months ago (2017-01-12 17:21:25 UTC) #18
scottmg
3 years, 11 months ago (2017-01-12 17:21:41 UTC) #19

Powered by Google App Engine
This is Rietveld 408576698