Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2627713005: Fix leaks in some parsers tests and triage remaining cc tests. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix leaks in some parsers tests and triage remaining cc tests. Issue #28342 Issue #28345 Issue #28347 Issue #28348 Issue #28349 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f12527455d9441fcd15a057aaf1e54f5475e7fcc

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -12 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +76 lines, -0 lines 0 comments Download
M runtime/vm/parser_test.cc View 16 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-11 20:42:14 UTC) #2
zra
https://codereview.chromium.org/2627713005/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2627713005/diff/1/runtime/tests/vm/vm.status#newcode170 runtime/tests/vm/vm.status:170: cc/Service_Profile: Fail # Issue 28342 Are some of these ...
3 years, 11 months ago (2017-01-11 20:49:28 UTC) #3
rmacnak
https://codereview.chromium.org/2627713005/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2627713005/diff/1/runtime/tests/vm/vm.status#newcode170 runtime/tests/vm/vm.status:170: cc/Service_Profile: Fail # Issue 28342 On 2017/01/11 20:49:28, zra ...
3 years, 11 months ago (2017-01-11 21:02:40 UTC) #4
zra
lgtm
3 years, 11 months ago (2017-01-11 21:05:53 UTC) #5
rmacnak
3 years, 11 months ago (2017-01-11 21:12:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f12527455d9441fcd15a057aaf1e54f5475e7fcc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698