chrome/browser/notifications/notification_browsertest.cc - Issue 26277010: Create content::WebContentsDestroyedWatcher, use it in many tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 26277010: Create content::WebContentsDestroyedWatcher, use it in many tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_browsertest.cc

diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc

index b246ebb5e25f54dfce3cdd02ecc25a5beab9fe81..de06963a734fa963a8692ec04614876ef58edd7f 100644

--- a/chrome/browser/notifications/notification_browsertest.cc

+++ b/chrome/browser/notifications/notification_browsertest.cc

@@ -856,12 +856,11 @@ IN_PROC_BROWSER_TEST_F(NotificationsTest, TestCloseTabWithPermissionInfobar) {

browser()->tab_strip_model()->ActivateTabAt(0, true);

ui_test_utils::NavigateToURL(browser(), GetTestPageURL());

ASSERT_TRUE(RequestPermissionAndWait(browser()));

- content::WindowedNotificationObserver observer(

- content::NOTIFICATION_WEB_CONTENTS_DESTROYED,

- content::NotificationService::AllSources());

+ content::WebContentsDestroyedWatcher destroyed_watcher(

+ browser()->tab_strip_model()->GetWebContentsAt(0));

browser()->tab_strip_model()->CloseWebContentsAt(0,

TabStripModel::CLOSE_NONE);

- observer.Wait();

+ destroyed_watcher.Wait();

}

IN_PROC_BROWSER_TEST_F(