Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge. (Closed)
Patch Set: 1-based categoryRank -> 0-based categoryIndex. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 1d5a8082c671fa145c82b3b447ced5cd12812b71..b683aa3f09562f9d9308c17ff0e4432f340169e1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -368,9 +368,15 @@ public class NewTabPage
}
}
+ public void trackSnippetOpened(
+ int windowOpenDisposition, SnippetArticle article, int categoryIndex) {
+ mSnippetsBridge.onSuggestionOpened(article, categoryIndex, windowOpenDisposition);
+ }
+
@Override
- public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
- mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
+ public void openSnippet(
+ int windowOpenDisposition, SnippetArticle article, int categoryIndex) {
+ trackSnippetOpened(windowOpenDisposition, article, categoryIndex);
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
if (article.mIsAssetDownload) {

Powered by Google App Engine
This is Rietveld 408576698