Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Unified Diff: ash/common/shelf/app_list_shelf_item_delegate.h

Issue 2627533002: Replace ShelfItemDelegate::GetTitle() with ShelfItem::title. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/app_list_shelf_item_delegate.h
diff --git a/ash/common/shelf/app_list_shelf_item_delegate.h b/ash/common/shelf/app_list_shelf_item_delegate.h
index 38840523999e816e49cfb2bcc76c8021699b1253..82a122d9f0496f9113bed9cc2b6b37bab384f777 100644
--- a/ash/common/shelf/app_list_shelf_item_delegate.h
+++ b/ash/common/shelf/app_list_shelf_item_delegate.h
@@ -15,8 +15,8 @@ class ShelfModel;
class AppListShelfItemDelegate : public ShelfItemDelegate {
public:
// Initializes the app list item in the shelf data model and creates an
- // AppListShelfItemDelegate which will be owned by |shelf_model|.
- static void CreateAppListItemAndDelegate(ShelfModel* shelf_model);
+ // AppListShelfItemDelegate which will be owned by |model|.
+ static void CreateAppListItemAndDelegate(ShelfModel* model);
AppListShelfItemDelegate();
~AppListShelfItemDelegate() override;
@@ -24,7 +24,6 @@ class AppListShelfItemDelegate : public ShelfItemDelegate {
// ShelfItemDelegate:
ShelfItemDelegate::PerformedAction ItemSelected(
const ui::Event& event) override;
- base::string16 GetTitle() override;
ShelfMenuModel* CreateApplicationMenu(int event_flags) override;
void Close() override;
« no previous file with comments | « no previous file | ash/common/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698