Replace ShelfItemDelegate::GetTitle() with ShelfItem::title.

chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h"
 
 #include <memory>
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 19 matching lines @@
 
 base::TimeDelta ArcAppDeferredLauncherItemController::GetActiveTime() const {
   return base::Time::Now() - start_time_;
 }
 
 ash::ShelfItemDelegate::PerformedAction
 ArcAppDeferredLauncherItemController::ItemSelected(const ui::Event& event) {
   return ash::ShelfItemDelegate::kNoAction;
 }
 
-base::string16 ArcAppDeferredLauncherItemController::GetTitle() {

[James Cook, 2017/01/11 01:23:37]

Q: Do ARC deferred items still have a tooltip with a name while they load?

[msw, 2017/01/11 02:17:31]

I made ArcAppDeferredLauncherBrowserTest.StartAppDeferred check this (lmk if you
think I should have a separate test or set of such tests...). I can also
manually test that on a physical device soon. From the code,
ArcAppDeferredLauncherItemController is instantiated for existing items:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_d...
AFAIK, arc deferred ShelfItems are actually constructed in
ChromeLauncherControllerImpl::InsertAppLauncherItem (as you guessed), which
initializes the title for use while pinned, launching, and running.

-  ArcAppListPrefs* arc_prefs =
-      ArcAppListPrefs::Get(launcher_controller()->profile());
-  DCHECK(arc_prefs);
-  std::unique_ptr<ArcAppListPrefs::AppInfo> app_info = arc_prefs->GetApp(
-      ArcAppWindowLauncherController::GetArcAppIdFromShelfAppId(app_id()));
-  if (!app_info) {
-    NOTREACHED();
-    return base::string16();
-  }
-
-  return base::UTF8ToUTF16(app_info->name);
-}
-
 ash::ShelfMenuModel*
 ArcAppDeferredLauncherItemController::CreateApplicationMenu(int event_flags) {
   return nullptr;
 }
 
 void ArcAppDeferredLauncherItemController::Close() {
   if (host_)
     host_->Close(app_id());
 }
 
 bool ArcAppDeferredLauncherItemController::IsVisible() const {
   return true;
 }
 
 void ArcAppDeferredLauncherItemController::Launch(ash::LaunchSource source,
                                                   int event_flags) {}
 
 ash::ShelfItemDelegate::PerformedAction
 ArcAppDeferredLauncherItemController::Activate(ash::LaunchSource source) {
   return ash::ShelfItemDelegate::kNoAction;
 }
 
 ChromeLauncherAppMenuItems
 ArcAppDeferredLauncherItemController::GetApplicationList(int event_flags) {
   return ChromeLauncherAppMenuItems();
 }