Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: chrome/browser/media/router/presentation_request_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Add missing dependency for extensions_renderer_resources target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_request_unittest.cc
diff --git a/chrome/browser/media/router/presentation_request_unittest.cc b/chrome/browser/media/router/presentation_request_unittest.cc
index 165b5d078795cfe0747ec25df504d71ebb3bd440..8144d73db26913d38aa52152c1d4c60496f2b02d 100644
--- a/chrome/browser/media/router/presentation_request_unittest.cc
+++ b/chrome/browser/media/router/presentation_request_unittest.cc
@@ -8,17 +8,17 @@
namespace media_router {
TEST(PresentationRequestTest, Equals) {
- GURL frame_url("http://www.site.com/");
+ url::Origin frame_origin(GURL("http://www.site.com/"));
std::vector<GURL> presentation_urls = {
GURL("http://www.example.com/presentation.html"),
GURL("http://www.example.net/alternate.html")};
PresentationRequest request1(RenderFrameHostId(1, 2), presentation_urls,
- frame_url);
+ frame_origin);
// Frame IDs are different.
PresentationRequest request2(RenderFrameHostId(3, 4), presentation_urls,
- frame_url);
+ frame_origin);
EXPECT_FALSE(request1.Equals(request2));
// Presentation URLs are different.
@@ -26,19 +26,19 @@ TEST(PresentationRequestTest, Equals) {
RenderFrameHostId(1, 2),
{GURL("http://www.example.net/presentation.html"),
GURL("http://www.example.com/presentation.html")},
- frame_url);
+ frame_origin);
EXPECT_FALSE(request1.Equals(request3));
// Frame URLs are different.
PresentationRequest request4(RenderFrameHostId(1, 2), presentation_urls,
- GURL("http://www.site.net/"));
+ url::Origin(GURL("http://www.site.net/")));
EXPECT_FALSE(request1.Equals(request4));
PresentationRequest request5(
RenderFrameHostId(1, 2),
{GURL("http://www.example.com/presentation.html"),
GURL("http://www.example.net/alternate.html")},
- GURL("http://www.site.com/"));
+ url::Origin(GURL("http://www.site.com/")));
EXPECT_TRUE(request1.Equals(request5));
}
« no previous file with comments | « chrome/browser/media/router/presentation_request.cc ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698