chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc - Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)

Patch Set: Add missing dependency for extensions_renderer_resources target Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/presentation_media_sinks_observer.cc ('k') | chrome/browser/media/router/presentation_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

diff --git a/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc b/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

index 96166a8b2b1eccc5ac18fc138fbc44b170321803..7e9cc6b4571638a6694d7394c672c6250fbc4aba 100644

--- a/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

+++ b/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

@@ -20,6 +20,10 @@ using testing::Return;

namespace media_router {

+namespace {

+constexpr char kOrigin[] = "https://google.com";

+} // namespace

class PresentationMediaSinksObserverTest : public ::testing::Test {

public:

PresentationMediaSinksObserverTest()

@@ -31,7 +35,7 @@ class PresentationMediaSinksObserverTest : public ::testing::Test {

observer_.reset(new PresentationMediaSinksObserver(

&router_, &listener_, MediaSourceForPresentationUrl(

GURL("http://example.com/presentation.html")),

- GURL("https://google.com")));

+ url::Origin(GURL(kOrigin))));

EXPECT_TRUE(observer_->Init());

}