Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/presentation_media_sinks_observer.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "chrome/browser/media/router/media_source_helper.h"
 #include "chrome/browser/media/router/mock_media_router.h"
 #include "chrome/browser/media/router/mock_screen_availability_listener.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "content/public/browser/presentation_screen_availability_listener.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 using testing::_;
 using testing::Mock;
 using testing::Return;
 
 namespace media_router {
 
+namespace {
+const url::Origin kOrigin = url::Origin((GURL("https://google.com")));

[mark a. foltz, 2017/01/17 21:30:45]

Don't use complex ctors in static declarations.

https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

Can you revert to doing this in the Test ctor?

Also, there are extra ().

[steimel, 2017/01/18 01:52:35]

Done.

+}  // namespace
+
 class PresentationMediaSinksObserverTest : public ::testing::Test {
  public:
   PresentationMediaSinksObserverTest()
       : listener_(GURL("http://example.com/presentation.html")) {}
   ~PresentationMediaSinksObserverTest() override {}
 
   void SetUp() override {
     EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).WillOnce(Return(true));
     observer_.reset(new PresentationMediaSinksObserver(
         &router_, &listener_, MediaSourceForPresentationUrl(
                                   GURL("http://example.com/presentation.html")),
-        GURL("https://google.com")));
+        kOrigin));
     EXPECT_TRUE(observer_->Init());
   }
 
   void TearDown() override {
     EXPECT_CALL(router_, UnregisterMediaSinksObserver(_));
     observer_.reset();
   }
 
   MockMediaRouter router_;
   MockScreenAvailabilityListener listener_;
@@ skipping 38 matching lines @@
   observer_->OnSinksReceived(result);
   EXPECT_TRUE(Mock::VerifyAndClearExpectations(&listener_));
 
   // |listener_| should get result since it changed to false.
   EXPECT_CALL(listener_, OnScreenAvailabilityChanged(false)).Times(1);
   observer_->OnSinksReceived(std::vector<MediaSink>());
   EXPECT_TRUE(Mock::VerifyAndClearExpectations(&listener_));
 }
 
 }  // namespace media_router