Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Add missing dependency for extensions_renderer_resources target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/media/router/media_source.h" 8 #include "chrome/browser/media/router/media_source.h"
9 #include "chrome/browser/media/router/media_source_helper.h" 9 #include "chrome/browser/media/router/media_source_helper.h"
10 #include "chrome/browser/media/router/mock_media_router.h" 10 #include "chrome/browser/media/router/mock_media_router.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 PresentationRequest request = 144 PresentationRequest request =
145 delegate_impl_->GetDefaultPresentationRequest(); 145 delegate_impl_->GetDefaultPresentationRequest();
146 146
147 // Should not trigger callback since route response is error. 147 // Should not trigger callback since route response is error.
148 std::unique_ptr<RouteRequestResult> result = RouteRequestResult::FromError( 148 std::unique_ptr<RouteRequestResult> result = RouteRequestResult::FromError(
149 "Error", RouteRequestResult::UNKNOWN_ERROR); 149 "Error", RouteRequestResult::UNKNOWN_ERROR);
150 delegate_impl_->OnRouteResponse(request, *result); 150 delegate_impl_->OnRouteResponse(request, *result);
151 EXPECT_TRUE(Mock::VerifyAndClearExpectations(this)); 151 EXPECT_TRUE(Mock::VerifyAndClearExpectations(this));
152 152
153 // Should not trigger callback since request doesn't match. 153 // Should not trigger callback since request doesn't match.
154 PresentationRequest different_request( 154 PresentationRequest different_request(RenderFrameHostId(100, 200),
155 RenderFrameHostId(100, 200), {presentation_url2_}, GURL(kFrameUrl)); 155 {presentation_url2_},
156 url::Origin(GURL(kFrameUrl)));
156 MediaRoute* media_route = new MediaRoute("differentRouteId", source2_, 157 MediaRoute* media_route = new MediaRoute("differentRouteId", source2_,
157 "mediaSinkId", "", true, "", true); 158 "mediaSinkId", "", true, "", true);
158 media_route->set_incognito(incognito); 159 media_route->set_incognito(incognito);
159 result = RouteRequestResult::FromSuccess(base::WrapUnique(media_route), 160 result = RouteRequestResult::FromSuccess(base::WrapUnique(media_route),
160 "differentPresentationId"); 161 "differentPresentationId");
161 delegate_impl_->OnRouteResponse(different_request, *result); 162 delegate_impl_->OnRouteResponse(different_request, *result);
162 EXPECT_TRUE(Mock::VerifyAndClearExpectations(this)); 163 EXPECT_TRUE(Mock::VerifyAndClearExpectations(this));
163 164
164 // Should trigger callback since request matches. 165 // Should trigger callback since request matches.
165 EXPECT_CALL(*this, OnDefaultPresentationStarted(_)).Times(1); 166 EXPECT_CALL(*this, OnDefaultPresentationStarted(_)).Times(1);
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 base::Unretained(this)); 315 base::Unretained(this));
315 delegate_impl_->SetDefaultPresentationUrls(main_frame_process_id_, 316 delegate_impl_->SetDefaultPresentationUrls(main_frame_process_id_,
316 main_frame_routing_id_, 317 main_frame_routing_id_,
317 presentation_urls_, callback); 318 presentation_urls_, callback);
318 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest()); 319 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());
319 PresentationRequest request1 = 320 PresentationRequest request1 =
320 delegate_impl_->GetDefaultPresentationRequest(); 321 delegate_impl_->GetDefaultPresentationRequest();
321 EXPECT_EQ(presentation_url1_, request1.presentation_urls()[0]); 322 EXPECT_EQ(presentation_url1_, request1.presentation_urls()[0]);
322 EXPECT_EQ(RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_), 323 EXPECT_EQ(RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_),
323 request1.render_frame_host_id()); 324 request1.render_frame_host_id());
324 EXPECT_EQ(frame_url, request1.frame_url()); 325 EXPECT_EQ(url::Origin(frame_url), request1.frame_origin());
325 326
326 // Set to a new default presentation URL 327 // Set to a new default presentation URL
327 std::vector<GURL> new_urls = {presentation_url2_}; 328 std::vector<GURL> new_urls = {presentation_url2_};
328 delegate_impl_->SetDefaultPresentationUrls( 329 delegate_impl_->SetDefaultPresentationUrls(
329 main_frame_process_id_, main_frame_routing_id_, new_urls, callback); 330 main_frame_process_id_, main_frame_routing_id_, new_urls, callback);
330 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest()); 331 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());
331 PresentationRequest request2 = 332 PresentationRequest request2 =
332 delegate_impl_->GetDefaultPresentationRequest(); 333 delegate_impl_->GetDefaultPresentationRequest();
333 EXPECT_EQ(presentation_url2_, request2.presentation_urls()[0]); 334 EXPECT_EQ(presentation_url2_, request2.presentation_urls()[0]);
334 EXPECT_EQ(RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_), 335 EXPECT_EQ(RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_),
335 request2.render_frame_host_id()); 336 request2.render_frame_host_id());
336 EXPECT_EQ(frame_url, request2.frame_url()); 337 EXPECT_EQ(url::Origin(frame_url), request2.frame_origin());
337 338
338 // Remove default presentation URL. 339 // Remove default presentation URL.
339 delegate_impl_->SetDefaultPresentationUrls(main_frame_process_id_, 340 delegate_impl_->SetDefaultPresentationUrls(main_frame_process_id_,
340 main_frame_routing_id_, 341 main_frame_routing_id_,
341 std::vector<GURL>(), callback); 342 std::vector<GURL>(), callback);
342 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest()); 343 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest());
343 } 344 }
344 345
345 TEST_F(PresentationServiceDelegateImplTest, DefaultPresentationUrlCallback) { 346 TEST_F(PresentationServiceDelegateImplTest, DefaultPresentationUrlCallback) {
346 RunDefaultPresentationUrlCallbackTest(false); 347 RunDefaultPresentationUrlCallbackTest(false);
(...skipping 13 matching lines...) Expand all
360 StrictMock<MockDefaultPresentationRequestObserver> observer; 361 StrictMock<MockDefaultPresentationRequestObserver> observer;
361 delegate_impl_->AddDefaultPresentationRequestObserver(&observer); 362 delegate_impl_->AddDefaultPresentationRequestObserver(&observer);
362 363
363 GURL frame_url(kFrameUrl); 364 GURL frame_url(kFrameUrl);
364 content::WebContentsTester::For(GetWebContents()) 365 content::WebContentsTester::For(GetWebContents())
365 ->NavigateAndCommit(frame_url); 366 ->NavigateAndCommit(frame_url);
366 367
367 std::vector<GURL> request1_urls = {presentation_url1_}; 368 std::vector<GURL> request1_urls = {presentation_url1_};
368 PresentationRequest observed_request1( 369 PresentationRequest observed_request1(
369 RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_), 370 RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_),
370 request1_urls, frame_url); 371 request1_urls, url::Origin(frame_url));
371 EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request1))) 372 EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request1)))
372 .Times(1); 373 .Times(1);
373 delegate_impl_->SetDefaultPresentationUrls( 374 delegate_impl_->SetDefaultPresentationUrls(
374 main_frame_process_id_, main_frame_routing_id_, request1_urls, callback); 375 main_frame_process_id_, main_frame_routing_id_, request1_urls, callback);
375 376
376 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest()); 377 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());
377 PresentationRequest request1 = 378 PresentationRequest request1 =
378 delegate_impl_->GetDefaultPresentationRequest(); 379 delegate_impl_->GetDefaultPresentationRequest();
379 EXPECT_TRUE(request1.Equals(observed_request1)); 380 EXPECT_TRUE(request1.Equals(observed_request1));
380 381
381 EXPECT_TRUE(Mock::VerifyAndClearExpectations(&observer)); 382 EXPECT_TRUE(Mock::VerifyAndClearExpectations(&observer));
382 383
383 std::vector<GURL> request2_urls = {presentation_url2_}; 384 std::vector<GURL> request2_urls = {presentation_url2_};
384 PresentationRequest observed_request2( 385 PresentationRequest observed_request2(
385 RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_), 386 RenderFrameHostId(main_frame_process_id_, main_frame_routing_id_),
386 request2_urls, frame_url); 387 request2_urls, url::Origin(frame_url));
387 EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request2))) 388 EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request2)))
388 .Times(1); 389 .Times(1);
389 delegate_impl_->SetDefaultPresentationUrls( 390 delegate_impl_->SetDefaultPresentationUrls(
390 main_frame_process_id_, main_frame_routing_id_, request2_urls, callback); 391 main_frame_process_id_, main_frame_routing_id_, request2_urls, callback);
391 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest()); 392 ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());
392 PresentationRequest request2 = 393 PresentationRequest request2 =
393 delegate_impl_->GetDefaultPresentationRequest(); 394 delegate_impl_->GetDefaultPresentationRequest();
394 EXPECT_TRUE(request2.Equals(observed_request2)); 395 EXPECT_TRUE(request2.Equals(observed_request2));
395 396
396 EXPECT_TRUE(Mock::VerifyAndClearExpectations(&observer)); 397 EXPECT_TRUE(Mock::VerifyAndClearExpectations(&observer));
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 base::Bind(&MockCreatePresentationConnnectionCallbacks:: 617 base::Bind(&MockCreatePresentationConnnectionCallbacks::
617 OnCreateConnectionSuccess, 618 OnCreateConnectionSuccess,
618 base::Unretained(&mock_create_connection_callbacks)), 619 base::Unretained(&mock_create_connection_callbacks)),
619 base::Bind( 620 base::Bind(
620 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, 621 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
621 base::Unretained(&mock_create_connection_callbacks))); 622 base::Unretained(&mock_create_connection_callbacks)));
622 } 623 }
623 #endif // !defined(OS_ANDROID) 624 #endif // !defined(OS_ANDROID)
624 625
625 } // namespace media_router 626 } // namespace media_router
OLDNEW
« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/media/router/test_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698