Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

extensions/renderer/resources/media_router_bindings.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var mediaRouter;
 
 define('media_router_bindings', [
     'content/public/renderer/frame_interfaces',
     'chrome/browser/media/router/mojo/media_router.mojom',
     'extensions/common/mojo/keep_alive.mojom',
     'mojo/common/time.mojom',
     'mojo/public/js/bindings',
+    'url/mojo/origin.mojom',
 ], function(frameInterfaces,
             mediaRouterMojom,
             keepAliveMojom,
             timeMojom,
-            bindings) {
+            bindings,
+            originMojom) {
   'use strict';
 
   /**
    * Converts a media sink to a MediaSink Mojo object.
    * @param {!MediaSink} sink A media sink.
    * @return {!mediaRouterMojom.MediaSink} A Mojo MediaSink object.
    */
   function sinkToMojo_(sink) {
     return new mediaRouterMojom.MediaSink({
       'name': sink.friendlyName,
@@ skipping 109 matching lines @@
       case 'went_away':
         return PresentationConnectionCloseReason.WENT_AWAY;
       default:
         console.error('Unknown presentation connection close reason : ' +
             reason);
         return PresentationConnectionCloseReason.CONNECTION_ERROR;
     }
   }
 
   /**
+   * Converts Mojo origin to string.
+   * @param {!originMojom.Origin} Mojo origin
+   * @return {!string}
+   */
+  function mojoOriginToString_(origin) {

[mark a. foltz, 2017/02/02 23:05:08]

Please file a crbug to remove this conversion once the component understands
Origin objects and add a TODO(crbug.com/XXX) here and below.

[steimel, 2017/02/03 00:17:31]

Done.

+    if (origin.unique) {
+      return '';
+    }
+    var serializedOrigin = origin.scheme + '://' + origin.host;

[mark a. foltz, 2017/02/02 23:05:08]

This could be a one liner with an ES6 template string.  There's a performance
penalty, but I don't think it's worth optimizing given that the APIs that pass
origins aren't called often.

https://hacks.mozilla.org/2015/05/es6-in-depth-template-strings-2/

[steimel, 2017/02/03 00:17:31]

Done.

+    if (origin.port) {
+      serializedOrigin += ':' + origin.port;
+    }
+    serializedOrigin += '/';
+    return serializedOrigin;
+  }
+
+  /**
+   * Converts string to Mojo origin.
+   * @param {!string} string origin
+   * @return {!originMojom.Origin}
+   */
+  function stringToMojoOrigin_(string) {
+    try {
+      var url = new URL(string);

[mark a. foltz, 2017/02/02 23:05:08]

Is URL defined by the bindings for mojo URL?

[steimel, 2017/02/03 00:17:31]

This is a native js URL object, not a mojo URL object:
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL

+    } catch (err) {
+      if (string !== '') {

[mark a. foltz, 2017/02/02 23:05:08]

Nit: I would put this check first, then attempt to parse.

[steimel, 2017/02/03 00:17:31]

Done.

+        console.error('Invalid URL: ' + string);
+      }
+      return new originMojom.Origin({ unique: true });
+    }
+    var origin = new originMojom.Origin();
+    origin.scheme = url.protocol.replace(':', '');
+    origin.host = url.hostname;
+    if (url.port) {
+      origin.port = Number.parseInt(url.port);
+    }
+    return origin;
+  }
+
+  /**
    * Parses the given route request Error object and converts it to the
    * corresponding result code.
    * @param {!Error} error
    * @return {!mediaRouterMojom.RouteRequestResultCode}
    */
   function getRouteRequestResultCode_(error) {
     return error.errorCode ? error.errorCode :
       mediaRouterMojom.RouteRequestResultCode.UNKNOWN_ERROR;
   }
 
@@ skipping 90 matching lines @@
   /**
    * Called by the provider manager when a sink list for a given source is
    * updated.
    * @param {!string} sourceUrn
    * @param {!Array<!MediaSink>} sinks
    * @param {!Array<string>} origins
    */
   MediaRouter.prototype.onSinksReceived = function(sourceUrn, sinks,
       origins) {
     this.service_.onSinksReceived(sourceUrn, sinks.map(sinkToMojo_),
-        origins);
+        origins.map(stringToMojoOrigin_));
   };
 
   /**
    * Called by the provider manager when a sink is found to notify the MR of the
    * sink's ID. The actual sink will be returned through the normal sink list
    * update process, so this helps the MR identify the search result in the
    * list.
    * @param {string} pseudoSinkId  ID of the pseudo sink that started the
    *     search.
    * @param {string} sinkId ID of the newly-found sink.
@@ skipping 297 matching lines @@
   };
 
   /**
    * Requests that |sinkId| render the media referenced by |sourceUrn|. If the
    * request is from the Presentation API, then origin and tabId will
    * be populated.
    * @param {!string} sourceUrn Media source to render.
    * @param {!string} sinkId Media sink ID.
    * @param {!string} presentationId Presentation ID from the site
    *     requesting presentation. TODO(mfoltz): Remove.
-   * @param {!string} origin Origin of site requesting presentation.
+   * @param {!originMojom.Origin} origin Origin of site requesting presentation.
    * @param {!number} tabId ID of tab requesting presentation.
    * @param {!TimeDelta} timeout If positive, the timeout duration for the
    *     request. Otherwise, the default duration will be used.
    * @param {!boolean} incognito If true, the route is being requested by
    *     an incognito profile.
    * @return {!Promise.<!Object>} A Promise resolving to an object describing
    *     the newly created media route, or rejecting with an error message on
    *     failure.
    */
   MediaRouteProvider.prototype.createRoute =
       function(sourceUrn, sinkId, presentationId, origin, tabId,
                timeout, incognito) {
     this.handlers_.onBeforeInvokeHandler();
     return this.handlers_.createRoute(
-        sourceUrn, sinkId, presentationId, origin, tabId,
+        sourceUrn, sinkId, presentationId, mojoOriginToString_(origin), tabId,
         Math.floor(timeout.microseconds / 1000), incognito)
         .then(function(route) {
           return toSuccessRouteResponse_(route);
         },
         function(err) {
           return toErrorRouteResponse_(err);
         });
   };
 
   /**
    * Handles a request via the Presentation API to join an existing route given
    * by |sourceUrn| and |presentationId|. |origin| and |tabId| are used for
    * validating same-origin/tab scope.
    * @param {!string} sourceUrn Media source to render.
    * @param {!string} presentationId Presentation ID to join.
-   * @param {!string} origin Origin of site requesting join.
+   * @param {!originMojom.Origin} origin Origin of site requesting join.
    * @param {!number} tabId ID of tab requesting join.
    * @param {!TimeDelta} timeout If positive, the timeout duration for the
    *     request. Otherwise, the default duration will be used.
    * @param {!boolean} incognito If true, the route is being requested by
    *     an incognito profile.
    * @return {!Promise.<!Object>} A Promise resolving to an object describing
    *     the newly created media route, or rejecting with an error message on
    *     failure.
    */
   MediaRouteProvider.prototype.joinRoute =
       function(sourceUrn, presentationId, origin, tabId, timeout,
                incognito) {
     this.handlers_.onBeforeInvokeHandler();
     return this.handlers_.joinRoute(
-        sourceUrn, presentationId, origin, tabId,
+        sourceUrn, presentationId, mojoOriginToString_(origin), tabId,
         Math.floor(timeout.microseconds / 1000), incognito)
         .then(function(route) {
           return toSuccessRouteResponse_(route);
         },
         function(err) {
           return toErrorRouteResponse_(err);
         });
   };
 
   /**
    * Handles a request via the Presentation API to join an existing route given
    * by |sourceUrn| and |routeId|. |origin| and |tabId| are used for
    * validating same-origin/tab scope.
    * @param {!string} sourceUrn Media source to render.
    * @param {!string} routeId Route ID to join.
    * @param {!string} presentationId Presentation ID to join.
-   * @param {!string} origin Origin of site requesting join.
+   * @param {!originMojom.Origin} origin Origin of site requesting join.
    * @param {!number} tabId ID of tab requesting join.
    * @param {!TimeDelta} timeout If positive, the timeout duration for the
    *     request. Otherwise, the default duration will be used.
    * @param {!boolean} incognito If true, the route is being requested by
    *     an incognito profile.
    * @return {!Promise.<!Object>} A Promise resolving to an object describing
    *     the newly created media route, or rejecting with an error message on
    *     failure.
    */
   MediaRouteProvider.prototype.connectRouteByRouteId =
       function(sourceUrn, routeId, presentationId, origin, tabId,
                timeout, incognito) {
     this.handlers_.onBeforeInvokeHandler();
     return this.handlers_.connectRouteByRouteId(
-        sourceUrn, routeId, presentationId, origin, tabId,
+        sourceUrn, routeId, presentationId, mojoOriginToString_(origin), tabId,
         Math.floor(timeout.microseconds / 1000), incognito)
         .then(function(route) {
           return toSuccessRouteResponse_(route);
         },
         function(err) {
           return toErrorRouteResponse_(err);
         });
   };
 
   /**
@@ skipping 137 matching lines @@
     return Promise.resolve({
       'sink_id': this.handlers_.searchSinks(sinkId, sourceUrn, searchCriteria)
     });
   };
 
   mediaRouter = new MediaRouter(new mediaRouterMojom.MediaRouterPtr(
       frameInterfaces.getInterface(mediaRouterMojom.MediaRouter.name)));
 
   return mediaRouter;
 });