Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: pkg/analyzer/test/src/dart/sdk/sdk_test.dart

Issue 2627423004: Use spec.sum or strong.sum in EmbedderSdk. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/dart/sdk/sdk_test.dart
diff --git a/pkg/analyzer/test/src/dart/sdk/sdk_test.dart b/pkg/analyzer/test/src/dart/sdk/sdk_test.dart
index a32d03b273ff045fb1ce0c534ebdd1b93886f1e2..3abf7c2625dd148fc267c38344c96093f9b7a126 100644
--- a/pkg/analyzer/test/src/dart/sdk/sdk_test.dart
+++ b/pkg/analyzer/test/src/dart/sdk/sdk_test.dart
@@ -59,44 +59,36 @@ class EmbedderSdkTest extends EmbedderRelatedTest {
expectSource('$foxLib/deep/directory/part.dart', 'dart:deep/part.dart');
}
- void test_getLinkedBundle_hasBundle() {
- pathTranslator.newFileWithBytes(
- '$foxPath/sdk.ds', new PackageBundleAssembler().assemble().toBuffer());
+ void test_getLinkedBundle_noBundle() {
EmbedderYamlLocator locator = new EmbedderYamlLocator({
'fox': <Folder>[pathTranslator.getResource(foxLib)]
});
- // No bundle for spec mode.
- {
- EmbedderSdk sdk =
- new EmbedderSdk(resourceProvider, locator.embedderYamls);
- sdk.analysisOptions = new AnalysisOptionsImpl()..strongMode = false;
- sdk.useSummary = true;
- expect(sdk.getLinkedBundle(), isNull);
- }
- // Has bundle for strong mode.
- {
- EmbedderSdk sdk =
- new EmbedderSdk(resourceProvider, locator.embedderYamls);
- sdk.analysisOptions = new AnalysisOptionsImpl()..strongMode = true;
- sdk.useSummary = true;
- expect(sdk.getLinkedBundle(), isNotNull);
- }
- // Don't use bundle if not enabled.
- {
- EmbedderSdk sdk =
- new EmbedderSdk(resourceProvider, locator.embedderYamls);
- sdk.analysisOptions = new AnalysisOptionsImpl()..strongMode = true;
- sdk.useSummary = false;
- expect(sdk.getLinkedBundle(), isNull);
- }
+ EmbedderSdk sdk = new EmbedderSdk(resourceProvider, locator.embedderYamls);
+ expect(sdk.getLinkedBundle(), isNull);
}
- void test_getLinkedBundle_noBundle() {
+ void test_getLinkedBundle_spec() {
+ pathTranslator.newFileWithBytes('$foxPath/spec.sum',
+ new PackageBundleAssembler().assemble().toBuffer());
EmbedderYamlLocator locator = new EmbedderYamlLocator({
'fox': <Folder>[pathTranslator.getResource(foxLib)]
});
EmbedderSdk sdk = new EmbedderSdk(resourceProvider, locator.embedderYamls);
- expect(sdk.getLinkedBundle(), isNull);
+ sdk.analysisOptions = new AnalysisOptionsImpl()..strongMode = false;
+ sdk.useSummary = true;
+ expect(sdk.getLinkedBundle(), isNotNull);
+ }
+
+ void test_getLinkedBundle_strong() {
+ pathTranslator.newFileWithBytes('$foxPath/strong.sum',
+ new PackageBundleAssembler().assemble().toBuffer());
+ EmbedderYamlLocator locator = new EmbedderYamlLocator({
+ 'fox': <Folder>[pathTranslator.getResource(foxLib)]
+ });
+ EmbedderSdk sdk = new EmbedderSdk(resourceProvider, locator.embedderYamls);
+ sdk.analysisOptions = new AnalysisOptionsImpl()..strongMode = true;
+ sdk.useSummary = true;
+ expect(sdk.getLinkedBundle(), isNotNull);
}
void test_getSdkLibrary() {
« pkg/analyzer/lib/src/dart/sdk/sdk.dart ('K') | « pkg/analyzer/lib/src/dart/sdk/sdk.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698