Issue 2627423004: Use spec.sum or strong.sum in EmbedderSdk.

Issue 2627423004: Use spec.sum or strong.sum in EmbedderSdk. (Closed)

Created:
3 years, 11 months ago by scheglov

Modified:
3 years, 11 months ago

Reviewers:
devoncarew, pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use spec.sum or strong.sum in EmbedderSdk. R=brianwilkerson@google.com, devoncarew@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c5b994750e98982c3d1ff733bc799bfff01f5d87

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -44 lines)			Patch
	M	pkg/analyzer/lib/src/dart/sdk/sdk.dart	View		3 chunks	+13 lines, -15 lines	1 comment	Download
	M	pkg/analyzer/test/src/dart/sdk/sdk_test.dart	View		1 chunk	+21 lines, -29 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

lgtm Thanks! https://codereview.chromium.org/2627423004/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right): https://codereview.chromium.org/2627423004/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart#newcode310 pkg/analyzer/lib/src/dart/sdk/sdk.dart:310: 'Failed to load SDK analysis summary from ...

3 years, 11 months ago (2017-01-13 18:26:22 UTC) #3

scheglov

3 years, 11 months ago (2017-01-13 18:29:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c5b994750e98982c3d1ff733bc799bfff01f5d87 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages