Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2627393002: Replace std::map with std::pair for (origin, engagement) tuples in RenderFrameImpl. (Closed)
Patch Set: Address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 760
761 int id_; 761 int id_;
762 bool notify_result_; 762 bool notify_result_;
763 int routing_id_; 763 int routing_id_;
764 base::WeakPtr<RenderFrameImpl> render_frame_impl_; 764 base::WeakPtr<RenderFrameImpl> render_frame_impl_;
765 765
766 DISALLOW_COPY_AND_ASSIGN(JavaScriptIsolatedWorldRequest); 766 DISALLOW_COPY_AND_ASSIGN(JavaScriptIsolatedWorldRequest);
767 }; 767 };
768 768
769 typedef std::map<GURL, double> HostZoomLevels; 769 typedef std::map<GURL, double> HostZoomLevels;
770 typedef std::map<url::Origin, blink::mojom::EngagementLevel> EngagementLevels; 770 typedef std::pair<url::Origin, blink::mojom::EngagementLevel>
771 EngagementOriginAndLevel;
771 772
772 // Creates a new RenderFrame. |render_view| is the RenderView object that this 773 // Creates a new RenderFrame. |render_view| is the RenderView object that this
773 // frame belongs to. 774 // frame belongs to.
774 // Callers *must* call |BindToWebFrame| immediately after creation. 775 // Callers *must* call |BindToWebFrame| immediately after creation.
775 static RenderFrameImpl* Create(RenderViewImpl* render_view, 776 static RenderFrameImpl* Create(RenderViewImpl* render_view,
776 int32_t routing_id); 777 int32_t routing_id);
777 778
778 // This is called right after creation with the WebLocalFrame for this 779 // This is called right after creation with the WebLocalFrame for this
779 // RenderFrame. It must be called before Initialize. 780 // RenderFrame. It must be called before Initialize.
780 void BindToWebFrame(blink::WebLocalFrame* web_frame); 781 void BindToWebFrame(blink::WebLocalFrame* web_frame);
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1349 PepperPluginInstanceImpl* focused_pepper_plugin_; 1350 PepperPluginInstanceImpl* focused_pepper_plugin_;
1350 1351
1351 // The plugin instance that received the last mouse event. It is set to NULL 1352 // The plugin instance that received the last mouse event. It is set to NULL
1352 // if the last mouse event went to elements other than Pepper plugins. 1353 // if the last mouse event went to elements other than Pepper plugins.
1353 // |pepper_last_mouse_event_target_| is not owned by this class. We depend on 1354 // |pepper_last_mouse_event_target_| is not owned by this class. We depend on
1354 // the RenderFrameImpl to NULL it out when it destructs. 1355 // the RenderFrameImpl to NULL it out when it destructs.
1355 PepperPluginInstanceImpl* pepper_last_mouse_event_target_; 1356 PepperPluginInstanceImpl* pepper_last_mouse_event_target_;
1356 #endif 1357 #endif
1357 1358
1358 HostZoomLevels host_zoom_levels_; 1359 HostZoomLevels host_zoom_levels_;
1359 EngagementLevels engagement_levels_; 1360 EngagementOriginAndLevel engagement_level_;
1360 1361
1361 mojo::AssociatedBinding<blink::mojom::EngagementClient> engagement_binding_; 1362 mojo::AssociatedBinding<blink::mojom::EngagementClient> engagement_binding_;
1362 mojo::Binding<mojom::Frame> frame_binding_; 1363 mojo::Binding<mojom::Frame> frame_binding_;
1363 mojo::AssociatedBinding<mojom::HostZoom> host_zoom_binding_; 1364 mojo::AssociatedBinding<mojom::HostZoom> host_zoom_binding_;
1364 mojom::FrameHostPtr frame_host_; 1365 mojom::FrameHostPtr frame_host_;
1365 1366
1366 // Indicates whether |didAccessInitialDocument| was called. 1367 // Indicates whether |didAccessInitialDocument| was called.
1367 bool has_accessed_initial_document_; 1368 bool has_accessed_initial_document_;
1368 1369
1369 AssociatedInterfaceRegistryImpl associated_interfaces_; 1370 AssociatedInterfaceRegistryImpl associated_interfaces_;
1370 std::unique_ptr<AssociatedInterfaceProviderImpl> 1371 std::unique_ptr<AssociatedInterfaceProviderImpl>
1371 remote_associated_interfaces_; 1372 remote_associated_interfaces_;
1372 1373
1373 // TODO(dcheng): Remove these members. 1374 // TODO(dcheng): Remove these members.
1374 bool committed_first_load_ = false; 1375 bool committed_first_load_ = false;
1375 bool name_changed_before_first_commit_ = false; 1376 bool name_changed_before_first_commit_ = false;
1376 1377
1377 bool browser_side_navigation_pending_ = false; 1378 bool browser_side_navigation_pending_ = false;
1378 1379
1379 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1380 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1380 1381
1381 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1382 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1382 }; 1383 };
1383 1384
1384 } // namespace content 1385 } // namespace content
1385 1386
1386 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1387 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698