Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2627353002: Create vector icon directory for resources used by controls in ui/views. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create vector icon directory for resources used by controls in ui/views. BUG=626786

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix win? #

Patch Set 4 : fix win? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -193 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 3 chunks +0 lines, -12 lines 0 comments Download
D ui/gfx/vector_icons/checkbox_active.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/gfx/vector_icons/checkbox_normal.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/gfx/vector_icons/combobox_arrow_mac_disabled.icon View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gfx/vector_icons/combobox_arrow_mac_enabled.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/gfx/vector_icons/menu_check.icon View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/gfx/vector_icons/menu_check.1x.icon View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/gfx/vector_icons/menu_radio_empty.icon View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/gfx/vector_icons/menu_radio_selected.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/gfx/vector_icons/radio_button_active.icon View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/gfx/vector_icons/radio_button_normal.icon View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/gfx/vector_icons/submenu_arrow.icon View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/gfx/vector_icons/submenu_arrow.1x.icon View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/checkbox.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/views/controls/button/radio_button.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
A ui/views/resources/vector_icons/BUILD.gn View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A + ui/views/resources/vector_icons/checkbox_active.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/checkbox_normal.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/combobox_arrow_mac_disabled.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/combobox_arrow_mac_enabled.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/menu_check.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/menu_check.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/menu_radio_empty.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/menu_radio_selected.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/radio_button_active.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/radio_button_normal.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/submenu_arrow.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/resources/vector_icons/submenu_arrow.1x.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/views/resources/vector_icons/vector_icons.cc.template View 3 1 chunk +25 lines, -0 lines 0 comments Download
A ui/views/resources/vector_icons/vector_icons.h.template View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Evan Stade
3 years, 11 months ago (2017-01-14 01:01:18 UTC) #14
sky
LGTM
3 years, 11 months ago (2017-01-17 17:33:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627353002/60001
3 years, 11 months ago (2017-01-17 17:47:00 UTC) #17
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-17 19:07:46 UTC) #20
Evan Stade
3 years, 11 months ago (2017-01-18 00:19:28 UTC) #21
On 2017/01/17 19:07:46, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

landed as crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064

Powered by Google App Engine
This is Rietveld 408576698