Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627343004: Revert "Add support for the new function-type syntax." (Closed)

Created:
3 years, 11 months ago by floitsch
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add support for the new function-type syntax." This reverts commit 85227ba8a60332a18ae92cb1b87bf15d52a909bd. Committed: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -1614 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -10 lines 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 3 chunks +2 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 4 chunks +8 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 4 chunks +7 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 13 chunks +50 lines, -220 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 6 chunks +6 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 10 chunks +15 lines, -193 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 3 chunks +3 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 18 chunks +14 lines, -95 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 4 chunks +7 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 3 chunks +3 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
D tests/language/generalized_function_type_test.dart View 1 chunk +0 lines, -791 lines 0 comments Download
D tests/language/generic_function_typedef2_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/generic_function_typedef_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
floitsch
Needed to revert. Some errors were just status-file updates, but I also have now dart2js ...
3 years, 11 months ago (2017-01-13 15:49:45 UTC) #2
floitsch
3 years, 11 months ago (2017-01-13 15:50:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698