Issue 26273003: Pool future creation to ensure no more than 10 ops are in flight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26273003: Pool future creation to ensure no more than 10 ops are in flight (Closed)

Created:
7 years, 2 months ago by kevmoo-old

Modified:
7 years, 2 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pool future creation to ensure no more than 10 ops are in flight BUG=https://code.google.com/p/dart/issues/detail?id=13752

Patch Set 1 #

Patch Set 2 : using in polymer #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -22 lines)			Patch
M	pkg/barback/lib/src/phase.dart	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View		5 chunks	+16 lines, -9 lines	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/src/build/runner.dart	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

7 years, 2 months ago (2013-10-08 14:42:19 UTC) #1

Times for building my NV.dart app - seems like a statistically significant
speedup--but only ~5%

Just use Future.forEach

Test  1 of 10 - 0:00:04.143000
Test  2 of 10 - 0:00:04.231000
Test  3 of 10 - 0:00:04.314000
Test  4 of 10 - 0:00:04.278000
Test  5 of 10 - 0:00:04.357000
Test  6 of 10 - 0:00:04.323000
Test  7 of 10 - 0:00:04.384000
Test  8 of 10 - 0:00:04.409000
Test  9 of 10 - 0:00:04.378000
Test 10 of 10 - 0:00:04.534000
Min      0:00:04.143000
Max      0:00:04.534000
Media    0:00:04.340000
Mean     0:00:04.335000
StdDev   0:00:00.100000
StdErr   0:00:00.031000

Using new method with group count of 10

Test  1 of 10 - 0:00:03.924000
Test  2 of 10 - 0:00:03.860000
Test  3 of 10 - 0:00:03.970000
Test  4 of 10 - 0:00:04.040000
Test  5 of 10 - 0:00:04.240000
Test  6 of 10 - 0:00:04.163000
Test  7 of 10 - 0:00:04.437000
Test  8 of 10 - 0:00:04.376000
Test  9 of 10 - 0:00:04.207000
Test 10 of 10 - 0:00:04.274000
Min      0:00:03.860000
Max      0:00:04.437000
Media    0:00:04.185000
Mean     0:00:04.149000
StdDev   0:00:00.184000
StdErr   0:00:00.058000

Expand Messages | Collapse Messages