Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: pkg/analysis_server/test/context_manager_driver_test.dart

Issue 2627293002: Split "_Driver" tests to separate test files. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/context_manager_driver_test.dart
diff --git a/pkg/analysis_server/test/context_manager_driver_test.dart b/pkg/analysis_server/test/context_manager_driver_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..c48c98c91a06d046b243aeab27944c710f5f64f7
--- /dev/null
+++ b/pkg/analysis_server/test/context_manager_driver_test.dart
@@ -0,0 +1,121 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import 'context_manager_test.dart';
+
+main() {
+ defineReflectiveSuite(() {
+ defineReflectiveTests(AbstractContextManagerTest_Driver);
+ defineReflectiveTests(ContextManagerWithNewOptionsTest_Driver);
+ defineReflectiveTests(ContextManagerWithOldOptionsTest_Driver);
+ });
+}
+
+@reflectiveTest
+class AbstractContextManagerTest_Driver extends AbstractContextManagerTest {
+ bool get enableAnalysisDriver => true;
+
+ @failingTest
+ test_embedder_added() {
+ // NoSuchMethodError: The getter 'apiSignature' was called on null.
+ // Receiver: null
+ // Tried calling: apiSignature
+ // dart:core Object.noSuchMethod
+ // package:analyzer/src/dart/analysis/driver.dart 460:20 AnalysisDriver.configure
+ // package:analysis_server/src/context_manager.dart 1043:16 ContextManagerImpl._checkForPackagespecUpdate
+ // package:analysis_server/src/context_manager.dart 1553:5 ContextManagerImpl._handleWatchEvent
+ //return super.test_embedder_added();
+ fail('NoSuchMethodError');
+ }
+
+ @failingTest
+ test_embedder_packagespec() async {
+ // NoSuchMethodError: The getter 'apiSignature' was called on null.
+ // Receiver: null
+ // Tried calling: apiSignature
+ // dart:core Object.noSuchMethod
+ // package:analyzer/src/dart/analysis/driver.dart 248:20 AnalysisDriver.AnalysisDriver
+ // test/context_manager_test.dart 2698:25 TestContextManagerCallbacks.addAnalysisDriver
+ // package:analysis_server/src/context_manager.dart 1186:39 ContextManagerImpl._createContext
+ // package:analysis_server/src/context_manager.dart 1247:16 ContextManagerImpl._createContexts
+ // package:analysis_server/src/context_manager.dart 886:9 ContextManagerImpl.setRoots
+ // test/context_manager_test.dart 154:13 AbstractContextManagerTest.test_embedder_packagespec.<async>
+ return super.test_embedder_packagespec();
+ }
+}
+
+@reflectiveTest
+class ContextManagerWithNewOptionsTest_Driver
+ extends ContextManagerWithNewOptionsTest {
+ bool get enableAnalysisDriver => true;
+
+ @failingTest
+ test_analysis_options_file_delete_with_embedder() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
+ return super.test_analysis_options_file_delete_with_embedder();
+ }
+
+ @failingTest
+ test_embedder_options() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
+ return super.test_embedder_options();
+ }
+
+ @failingTest
+ test_optionsFile_update_strongMode() async {
+ // It appears that this fails because we are not correctly updating the
+ // analysis options in the driver when the file is modified.
+ //return super.test_optionsFile_update_strongMode();
+ // After a few other changes, the test now times out on my machine, so I'm
+ // disabling it in order to prevent it from being flaky.
+ fail('Test times out');
+ }
+
+ @failingTest
+ test_path_filter_analysis_option() async {
+ // This fails because we're not analyzing the analyis options file.
+ return super.test_path_filter_analysis_option();
+ }
+}
+
+@reflectiveTest
+class ContextManagerWithOldOptionsTest_Driver
+ extends ContextManagerWithOldOptionsTest {
+ bool get enableAnalysisDriver => true;
+
+ @failingTest
+ test_analysis_options_file_delete_with_embedder() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
+ return super.test_analysis_options_file_delete_with_embedder();
+ }
+
+ @failingTest
+ test_embedder_options() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
+ return super.test_embedder_options();
+ }
+
+ @failingTest
+ test_optionsFile_update_strongMode() async {
+ // It appears that this fails because we are not correctly updating the
+ // analysis options in the driver when the file is modified.
+ //return super.test_optionsFile_update_strongMode();
+ // After a few other changes, the test now times out on my machine, so I'm
+ // disabling it in order to prevent it from being flaky.
+ fail('Test times out');
+ }
+
+ @failingTest
+ test_path_filter_analysis_option() async {
+ // This fails because we're not analyzing the analyis options file.
+ return super.test_path_filter_analysis_option();
+ }
+}
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698