Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627293002: Split "_Driver" tests to separate test files. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split "_Driver" tests to separate test files. This avoids timeouts on my machine. Also it makes it easier to disable these tests when necessary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c6206ea1dec40fc3ea9ab4911825953ae53f5762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -283 lines) Patch
A pkg/analysis_server/test/context_manager_driver_test.dart View 1 chunk +121 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +0 lines, -108 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/error_driver_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 2 chunks +0 lines, -18 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/lint_driver_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/lint_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 6 chunks +6 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/update_content_driver_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
A pkg/analysis_server/test/integration/completion/get_suggestions_driver_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/integration/completion/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/checked_mode_compile_time_error_code_driver_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 2 chunks +0 lines, -8 lines 0 comments Download
A pkg/analyzer/test/generated/error_suppression_driver_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
A pkg/analyzer/test/generated/non_hint_code_driver_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
A pkg/analyzer/test/generated/resolver_driver_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +0 lines, -20 lines 0 comments Download
A pkg/analyzer/test/generated/static_type_analyzer_driver_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
A pkg/analyzer/test/generated/static_type_warning_code_driver_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 3 chunks +0 lines, -21 lines 0 comments Download
A pkg/analyzer/test/generated/strong_mode_driver_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 4 chunks +0 lines, -66 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 6 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-12 15:24:32 UTC) #2
scheglov
lgtm
3 years, 11 months ago (2017-01-12 15:47:31 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-12 16:19:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c6206ea1dec40fc3ea9ab4911825953ae53f5762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698