Implement navigator.hardwareConcurrency

Implement navigator.hardwareConcurrency

This CL implements a |hardwareConcurrency| property on the
|navigator| object that returns the number of CPU cores the
machine has.

Intent-to-ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xwl0ab20hVc

R=esprehn@chromium.org
BUG=369629
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175629

[Rik, 2014-05-18 23:18:30]

These changes look reasonable. FYI I landed this attribute in WebKit too.

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
File Source/core/frame/NavigatorCPU.cpp (right):

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
Source/core/frame/NavigatorCPU.cpp:14: return
blink::Platform::current()->numberOfProcessors();
Do you want to limit the returned number to limit fingerprinting?

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
File Source/core/frame/NavigatorCPU.idl (right):

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
Source/core/frame/NavigatorCPU.idl:7: ] interface NavigatorCPU {
This is a strange diff. Is there a conflict?

[Daniel Bratell, 2014-05-22 12:56:21]

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
File Source/core/frame/NavigatorCPU.idl (right):

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
Source/core/frame/NavigatorCPU.idl:7: ] interface NavigatorCPU {
On 2014/05/18 23:18:30, Rik wrote:
> This is a strange diff. Is there a conflict?

Just the system thinking this is a modified copy of an existing file rather than
a new file. Add --no-find-copies to git cl upload if it becomes a problem.

[Rik, 2014-05-22 13:41:53]

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
File Source/core/frame/NavigatorCPU.idl (right):

https://codereview.chromium.org/262723002/diff/1/Source/core/frame/NavigatorC...
Source/core/frame/NavigatorCPU.idl:7: ] interface NavigatorCPU {
On 2014/05/22 12:56:22, Daniel Bratell wrote:
> On 2014/05/18 23:18:30, Rik wrote:
> > This is a strange diff. Is there a conflict?
> 
> Just the system thinking this is a modified copy of an existing file rather
than
> a new file. Add --no-find-copies to git cl upload if it becomes a problem.

OK. The spec changed to the attribute from 'cores' to 'hardwareConcurrency' so
this patch needs to make that change.
http://wiki.whatwg.org/wiki/NavigatorCores#Example_use_cases

[abarth-chromium, 2014-06-04 06:01:12]

@esprehn: This is ready for review.  Thanks!

[eseidel, 2014-06-04 06:19:54]

lgtm

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
File Source/core/frame/Navigator.h (right):

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
Source/core/frame/Navigator.h:45: class Navigator FINAL : public
RefCountedWillBeGarbageCollectedFinalized<Navigator>, public NavigatorCPU,
public NavigatorID, public NavigatorLanguage, public NavigatorOnLine, public
ScriptWrappable, public DOMWindowProperty, public
WillBeHeapSupplementable<Navigator> {
it may be time to line wrap. :)

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
File Source/core/frame/NavigatorCPU.h (right):

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
Source/core/frame/NavigatorCPU.h:12: unsigned hardwareConcurrency();
const?

[esprehn, 2014-06-05 01:06:52]

lgtm, couple nits before landing.

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/cpu/har...
File LayoutTests/fast/cpu/hardware-concurrency.html (right):

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/cpu/har...
LayoutTests/fast/cpu/hardware-concurrency.html:1: <script>
Add a doctype.

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
File LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html
(right):

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html:2: <html>
Leave out <html>, <head> and <body>.

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html:4: <pre
id='console'></pre>
You don't need this if you use js-test.js

https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html:9:
document.getElementById('console').appendChild(document.createTextNode(message +
"\n"));
Why not just js-test.js for this? js-test has async test support and a debug
function that appends to it's log.

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
File Source/core/frame/NavigatorCPU.h (right):

https://codereview.chromium.org/262723002/diff/20001/Source/core/frame/Naviga...
Source/core/frame/NavigatorCPU.h:12: unsigned hardwareConcurrency();
Yeah lets const it. :)

[abarth-chromium, 2014-06-05 04:46:42]

On 2014/06/05 01:06:52, esprehn wrote:
>
https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
> LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html:4: <pre
> id='console'></pre>
> You don't need this if you use js-test.js
> 
>
https://codereview.chromium.org/262723002/diff/20001/LayoutTests/fast/workers...
> LayoutTests/fast/workers/worker-navigator-hardware-concurrency.html:9:
> document.getElementById('console').appendChild(document.createTextNode(message
+
> "\n"));
> Why not just js-test.js for this? js-test has async test support and a debug
> function that appends to it's log.

I was just being consistent with some of the other worker tests in this
directory.  I don't think js-test adds much to this test and there's some value
in having the test stand alone.

[abarth-chromium, 2014-06-05 04:59:56]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-05 05:00:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/262723002/40001

[commit-bot: I haz the power, 2014-06-05 06:15:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10717)

[commit-bot: I haz the power, 2014-06-05 07:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 07:11:22]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10730)

[abarth-chromium, 2014-06-05 21:27:41]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:27:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/262723002/40001

[commit-bot: I haz the power, 2014-06-05 22:25:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10853)

[commit-bot: I haz the power, 2014-06-05 23:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 23:57:31]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10853)

[abarth-chromium, 2014-06-06 00:52:58]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-06 00:53:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/262723002/40001

[commit-bot: I haz the power, 2014-06-06 01:57:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10895)

[commit-bot: I haz the power, 2014-06-06 03:20:59]

Change committed as 175629