Fasta source builders.

Fasta source builders.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/61d4fe20e0473c077e17b0fdf56ef554b9f3473e

[ahe, 2017-01-13 12:25:45]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-01-16 15:12:45]

lgtm

https://codereview.chromium.org/2627223005/diff/1/pkg/fasta/lib/src/source/so...
File pkg/fasta/lib/src/source/source_class_builder.dart (right):

https://codereview.chromium.org/2627223005/diff/1/pkg/fasta/lib/src/source/so...
pkg/fasta/lib/src/source/source_class_builder.dart:72:
cls.addMember(builder.build(library.library));
Why not join these two cases?

[ahe, 2017-01-16 15:32:17]

Thank you, Johnni!

https://codereview.chromium.org/2627223005/diff/1/pkg/fasta/lib/src/source/so...
File pkg/fasta/lib/src/source/source_class_builder.dart (right):

https://codereview.chromium.org/2627223005/diff/1/pkg/fasta/lib/src/source/so...
pkg/fasta/lib/src/source/source_class_builder.dart:72:
cls.addMember(builder.build(library.library));
On 2017/01/16 15:12:45, Johnni Winther wrote:
> Why not join these two cases?

I don't have a common interface for the build method.

[ahe, 2017-01-16 15:33:11]

Description was changed from

==========
Fasta source builders.
==========

to

==========
Fasta source builders.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/61d4fe20e0473c077e17b0fdf56ef554b9f3473e
==========

[ahe, 2017-01-16 15:33:13]

Committed patchset #2 (id:20001) manually as
61d4fe20e0473c077e17b0fdf56ef554b9f3473e (presubmit successful).