Issue 2627203002: Fix service isolate initialization in PRODUCT mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2627203002: Fix service isolate initialization in PRODUCT mode. (Closed)

Created:
3 years, 11 months ago by Florian Schneider

Modified:
3 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix service isolate initialization in PRODUCT mode. My previous CL (removing noopt) incorrectly refactored this code and broke PRODUCT mode. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2dd8946fc4dbb7da44e80dd334cca75b29e50c05

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	runtime/lib/vmservice.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	runtime/vm/precompiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

3 years, 11 months ago (2017-01-12 02:08:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2dd8946fc4dbb7da44e80dd334cca75b29e50c05 (presubmit successful).