third_party/WebKit/Source/wtf/WTFThreadData.cpp - Issue 2627153004: Use TLS storage for thread ids in wtf/ThreadingPThreads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/WTFThreadData.cpp

Issue 2627153004: Use TLS storage for thread ids in wtf/ThreadingPThreads (Closed)

Patch Set: const Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/WTFThreadData.cpp

diff --git a/third_party/WebKit/Source/wtf/WTFThreadData.cpp b/third_party/WebKit/Source/wtf/WTFThreadData.cpp

index 33351aacb1c5166a40d7b050e03b730bc6d5b1d1..33abb350ad6961e7e70fada3cb27683297d177f4 100644

--- a/third_party/WebKit/Source/wtf/WTFThreadData.cpp

+++ b/third_party/WebKit/Source/wtf/WTFThreadData.cpp

@@ -35,7 +35,8 @@ ThreadSpecific<WTFThreadData>* WTFThreadData::staticData;

WTFThreadData::WTFThreadData()

: m_atomicStringTable(new AtomicStringTable),

- m_cachedConverterICU(new ICUConverterWrapper) {}

+ m_cachedConverterICU(new ICUConverterWrapper),

+ m_threadId(internal::currentThreadSyscall()) {}

esprehn 2017/01/12 19:59:11 How does this work on non-pthreads platforms? I th

Charlie Harrison 2017/01/12 20:07:46 Good catch yeah that would lead to link errors. I'

WTFThreadData::~WTFThreadData() {}

« no previous file with comments | « third_party/WebKit/Source/wtf/WTFThreadData.h ('k') | no next file » | no next file with comments »