Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h

Issue 2627123003: SharedWorker: Simplify connection sequence (Closed)
Patch Set: remove unnecessary forward declaration Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebSharedWorkerConnector.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
diff --git a/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h b/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
index b139ce63a69b1a1271236980cfa84e77abb80c20..db36308b342a2c7dbbd75eedcb58aae3b046ba0c 100644
--- a/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
+++ b/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
@@ -31,7 +31,6 @@
#ifndef WebSharedWorkerRepositoryClient_h
#define WebSharedWorkerRepositoryClient_h
-#include "WebSharedWorkerConnector.h"
#include "WebSharedWorkerCreationContextType.h"
#include "WebSharedWorkerCreationErrors.h"
#include "public/platform/WebAddressSpace.h"
@@ -40,6 +39,8 @@
namespace blink {
enum WebContentSecurityPolicyType;
+class WebMessagePortChannel;
+class WebSharedWorkerConnectListener;
class WebString;
class WebURL;
@@ -49,17 +50,16 @@ class WebSharedWorkerRepositoryClient {
// given process).
using DocumentID = unsigned long long;
- // Creates a new shared worker connector.
- virtual std::unique_ptr<WebSharedWorkerConnector> createSharedWorkerConnector(
- const WebURL& url,
- const WebString& name,
- DocumentID id,
- const WebString& contentSecurityPolicy,
- WebContentSecurityPolicyType,
- WebAddressSpace,
- WebSharedWorkerCreationContextType,
- WebWorkerCreationError* error) {
- return nullptr;
+ // Connects to a shared worker.
+ virtual void connect(const WebURL& url,
+ const WebString& name,
+ DocumentID id,
+ const WebString& contentSecurityPolicy,
+ WebContentSecurityPolicyType,
+ WebAddressSpace,
+ WebSharedWorkerCreationContextType,
+ WebMessagePortChannel*,
+ std::unique_ptr<blink::WebSharedWorkerConnectListener>) {
}
// Invoked when a document has been detached. DocumentID can be re-used after
« no previous file with comments | « third_party/WebKit/public/web/WebSharedWorkerConnector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698