DevTools: make cpu throttling manager a control factory we can reuse.

third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 53 matching lines @@
     // Create models.
     this._tracingModelBackingStorage = new Bindings.TempFileBackingStorage('tracing');
     this._tracingModel = new SDK.TracingModel(this._tracingModelBackingStorage);
     this._model = new TimelineModel.TimelineModel(Timeline.TimelineUIUtils.visibleEventsFilter());
     this._frameModel =
         new TimelineModel.TimelineFrameModel(event => Timeline.TimelineUIUtils.eventStyle(event).category.name);
     this._filmStripModel = new SDK.FilmStripModel(this._tracingModel);
     this._irModel = new TimelineModel.TimelineIRModel();
     /** @type {!Array<!{title: string, model: !SDK.TracingModel}>} */
     this._extensionTracingModels = [];
-    this._cpuThrottlingManager = new Timeline.CPUThrottlingManager();
+    this._cpuThrottlingManager = new Components.CPUThrottlingManager();
 
     /** @type {!Array<!Timeline.TimelineModeView>} */
     this._currentViews = [];
 
     this._captureJSProfileSetting = Common.settings.createSetting('timelineEnableJSSampling', true);
     this._captureLayersAndPicturesSetting = Common.settings.createSetting('timelineCaptureLayersAndPictures', false);
     this._captureFilmStripSetting = Common.settings.createSetting('timelineCaptureFilmStrip', false);
 
     this._showScreenshotsSetting = Common.settings.createLocalSetting('timelineShowScreenshots', false);
     this._showScreenshotsSetting.addChangeListener(this._onModeChanged, this);
@@ skipping 37 matching lines @@
     this._stackView.element.classList.add('timeline-view-stack');
 
     this._stackView.show(this._searchableView.element);
     this._onModeChanged();
 
     this._configureThrottlingSetting = Common.settings.createSetting('timelineConfigureThrottling', false);
     this._configureThrottlingButton = new UI.ToolbarSettingToggle(
         this._configureThrottlingSetting, 'largeicon-settings-gear', Common.UIString('Configure throttling'));
     SDK.multitargetNetworkManager.addEventListener(
         SDK.MultitargetNetworkManager.Events.ConditionsChanged, this._updateConfigureThrottlingButton.bind(this));
+    this._cpuThrottlingManager.addEventListener(
+        Components.CPUThrottlingManager.Events.RateChanged, this._updateConfigureThrottlingButton.bind(this));
     this._throttlingToolbar = new UI.Toolbar('', this.element);
-    this._cpuThrottlingCombobox = new UI.ToolbarComboBox(this._onCPUThrottlingChanged.bind(this));
+    this._cpuThrottlingCombobox = this._cpuThrottlingManager.createControl();

[caseq, 2017/01/12 02:59:12]

nit: make it local

     this._throttlingToolbar.appendText(Common.UIString('Network:'));
     this._throttlingToolbar.appendToolbarItem(this._createNetworkConditionsSelect());
     this._throttlingToolbar.appendSeparator();
     this._throttlingToolbar.appendText(Common.UIString('CPU:'));
     this._throttlingToolbar.appendToolbarItem(this._cpuThrottlingCombobox);
     this._throttlingToolbar.appendToolbarItem(new UI.ToolbarSeparator(true));
     var hideToolbarItem = new UI.ToolbarButton(Common.UIString('Close'), 'largeicon-delete');
     hideToolbarItem.addEventListener(UI.ToolbarButton.Events.Click, () => this._configureThrottlingSetting.set(false));
     this._throttlingToolbar.appendToolbarItem(hideToolbarItem);
-    this._populateCPUThrottingCombobox();
     this._configureThrottlingSetting.addChangeListener(this._updateThrottlingToolbarVisibility.bind(this));
     this._updateThrottlingToolbarVisibility();
 
     this._showLandingPage();
     this._recreateToolbarItems();
 
     Extensions.extensionServer.addEventListener(
         Extensions.ExtensionServer.Events.TraceProviderAdded, this._recreateToolbarItems, this);
 
     this._captureFilmStripSetting.addChangeListener(this._onModeChanged, this);
@@ skipping 208 matching lines @@
   /**
    * @return {!UI.ToolbarComboBox}
    */
   _createNetworkConditionsSelect() {
     var toolbarItem = new UI.ToolbarComboBox(null);
     toolbarItem.setMaxWidth(140);
     Components.NetworkConditionsSelector.decorateSelect(toolbarItem.selectElement());
     return toolbarItem;
   }
 
-  _populateCPUThrottingCombobox() {
-    var cpuThrottlingCombobox = this._cpuThrottlingCombobox;
-    cpuThrottlingCombobox.removeOptions();
-    var currentRate = this._cpuThrottlingManager.rate();
-    var hasSelection = false;
-    /**
-     * @param {string} name
-     * @param {number} value
-     */
-    function addOption(name, value) {
-      var option = cpuThrottlingCombobox.createOption(name, '', String(value));
-      cpuThrottlingCombobox.addOption(option);
-      if (hasSelection || (value && value !== currentRate))
-        return;
-      cpuThrottlingCombobox.select(option);
-      hasSelection = true;
-    }
-    addOption(Common.UIString('No throttling'), 1);
-    for (const rate of [2, 5, 10, 20])
-      addOption(Common.UIString('%d\xD7 slowdown', rate), rate);
-  }
-
   _prepareToLoadTimeline() {
     console.assert(this._state === Timeline.TimelinePanel.State.Idle);
     this._setState(Timeline.TimelinePanel.State.Loading);
   }
 
   _createFileSelector() {
     if (this._fileSelectorElement)
       this._fileSelectorElement.remove();
     this._fileSelectorElement = UI.createFileSelectorElement(this._loadFromFile.bind(this));
     this.element.appendChild(this._fileSelectorElement);
@@ skipping 94 matching lines @@
 
     if (showMemory) {
       this._addModeView(
           new Timeline.MemoryCountersGraph(this, this._model, [Timeline.TimelineUIUtils.visibleEventsFilter()]));
     }
 
     this.doResize();
     this.select(null);
   }
 
-  _onCPUThrottlingChanged() {
-    if (!this._cpuThrottlingManager)
-      return;
-    var text = this._cpuThrottlingCombobox.selectedOption().value;
-    this._cpuThrottlingManager.setRate(Number.parseFloat(text));
-    this._updateConfigureThrottlingButton();
-  }
-
   _updateThrottlingToolbarVisibility() {
     this._throttlingToolbar.element.classList.toggle('hidden', !this._configureThrottlingSetting.get());
   }
 
   _updateConfigureThrottlingButton() {
     var makeRed = this._cpuThrottlingManager.rate() !== 1 || SDK.multitargetNetworkManager.isThrottling();
     this._configureThrottlingButton.setDefaultWithRedColor(makeRed);
     this._configureThrottlingButton.setToggleWithRedColor(makeRed);
   }
 
@@ skipping 1345 matching lines @@
 };
 
 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSetting');
 
 /** @enum {symbol} */
 Timeline.TimelineFilters.Events = {
   FilterChanged: Symbol('FilterChanged')
 };
 
 Timeline.TimelineFilters._durationFilterPresetsMs = [0, 1, 15];
-
-/**
- * @implements {SDK.TargetManager.Observer}
- * @unrestricted
- */
-Timeline.CPUThrottlingManager = class extends Common.Object {
-  constructor() {
-    super();
-    this._targets = [];
-    this._throttlingRate = 1.;  // No throttling
-    SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);
-  }
-
-  /**
-   * @param {number} value
-   */
-  setRate(value) {
-    this._throttlingRate = value;
-    this._targets.forEach(target => target.emulationAgent().setCPUThrottlingRate(value));
-    var icon = null;
-    if (value !== 1) {
-      icon = UI.Icon.create('smallicon-warning');
-      icon.title = Common.UIString('CPU throttling is enabled');
-    }
-    UI.inspectorView.setPanelIcon('timeline', icon);
-  }
-
-  /**
-   * @return {number}
-   */
-  rate() {
-    return this._throttlingRate;
-  }
-
-  /**
-   * @override
-   * @param {!SDK.Target} target
-   */
-  targetAdded(target) {
-    this._targets.push(target);
-    target.emulationAgent().setCPUThrottlingRate(this._throttlingRate);
-  }
-
-  /**
-   * @override
-   * @param {!SDK.Target} target
-   */
-  targetRemoved(target) {
-    this._targets.remove(target, true);
-  }
-};