third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp - Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp

Issue 2627103003: [EditCommandSource] Pass source through |CompositeEditCommand| ctor instead of |apply(source)| (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp

index 5357b8e35e2e444e785e6b943538fe652c855396..0e4009f82ab484df2fd956c0ec4899e2f64e51ea 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp

@@ -41,10 +41,11 @@ TEST_F(ApplyStyleCommandTest, RemoveRedundantBlocksWithStarEditableStyle) {

MutableStylePropertySet* style =

MutableStylePropertySet::create(HTMLQuirksMode);

style->setProperty(CSSPropertyTextAlign, "center");

- ApplyStyleCommand::create(document(), EditingStyle::create(style),

+ ApplyStyleCommand::create(document(), EditCommandSource::kDOM,

+ EditingStyle::create(style),

InputEvent::InputType::FormatJustifyCenter,

ApplyStyleCommand::ForceBlockProperties)

- ->apply(EditCommandSource::kDOM);

+ ->apply();

// Shouldn't crash.

}