Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2627093010: Report errors like IMPORT_OF_NON_LIBRARY with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report errors like IMPORT_OF_NON_LIBRARY with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/914a11764958c9df580fb09e0514f53b05886f7e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +37 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 11 chunks +52 lines, -7 lines 2 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_driver_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-12 21:06:28 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2627093010/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/2627093010/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode119 pkg/analyzer/lib/src/task/dart.dart:119: * The errors produced while building a library ...
3 years, 11 months ago (2017-01-12 21:34:07 UTC) #2
scheglov
3 years, 11 months ago (2017-01-12 21:41:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
914a11764958c9df580fb09e0514f53b05886f7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698