Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2627093006: Add TEAM/COMPONENT information (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, zoltan1, eae+blinkwatch, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, jam, leviw+renderwatch, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, jchaffraix+rendering, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, anantha, ymzhang1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add TEAM/COMPONENT information BUG=679905

Patch Set 1 #

Total comments: 8

Patch Set 2 : updated based on comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M content/browser/hyphenation/OWNERS View 1 1 chunk +3 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/OWNERS View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/hyphenation/OWNERS View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/gardiner_mod/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 11 months ago (2017-01-12 00:49:16 UTC) #2
eae
https://codereview.chromium.org/2627093006/diff/1/content/browser/hyphenation/OWNERS File content/browser/hyphenation/OWNERS (right): https://codereview.chromium.org/2627093006/diff/1/content/browser/hyphenation/OWNERS#newcode6 content/browser/hyphenation/OWNERS:6: # COMPONENT: Internals>Core I'd add a TEAM: layout-dev@ line ...
3 years, 11 months ago (2017-01-12 00:56:06 UTC) #4
ymzhang1
Update TEAM/COMPONENT information. Replace team information for component Blink with blink-dev@chromium.org. https://codereview.chromium.org/2627093006/diff/1/content/browser/hyphenation/OWNERS File content/browser/hyphenation/OWNERS (right): ...
3 years, 11 months ago (2017-01-12 19:46:00 UTC) #5
eae
LGTM
3 years, 11 months ago (2017-01-12 19:51:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627093006/20001
3 years, 11 months ago (2017-01-12 19:54:55 UTC) #8
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 21:09:22 UTC) #11
stgao
https://codereview.chromium.org/2627093006/diff/20001/content/browser/hyphenation/OWNERS File content/browser/hyphenation/OWNERS (right): https://codereview.chromium.org/2627093006/diff/20001/content/browser/hyphenation/OWNERS#newcode6 content/browser/hyphenation/OWNERS:6: # TEAM: layout-dev@ nit: it would be great to ...
3 years, 11 months ago (2017-01-12 22:27:38 UTC) #12
tyoshino (SeeGerritForStatus)
3 years, 9 months ago (2017-03-22 09:41:43 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2627093006/diff/20001/content/browser/hyphena...
File content/browser/hyphenation/OWNERS (right):

https://codereview.chromium.org/2627093006/diff/20001/content/browser/hyphena...
content/browser/hyphenation/OWNERS:6: # TEAM: layout-dev@
On 2017/01/12 22:27:38, stgao(ping after 24h) wrote:
> nit: it would be great to make it consistent for a full email.
> 
> Same for other occurrences in this CL.

Created
https://codereview.chromium.org/2768773003/

Powered by Google App Engine
This is Rietveld 408576698